Update org.kde.Platform runtime to 5.15-21.08

flathub / com.obsproject.Studio

This repository is no longer used to build OBS. Issues should be reported at https://github.com/obsproject/obs-studio

https://github.com/obsproject/obs-studio

29 stars 21 forks source link

Update org.kde.Platform runtime to 5.15-21.08 #156

Closed tim77 closed 2 years ago

tim77 commented 2 years ago

Also mbedtls to v2.27.0. Mandatory update for org.kde.Platform 5.15-21.08 runtime.

tim77 commented 2 years ago

bot, build com.obsproject.Studio

flathubbot commented 2 years ago

Queued test build for com.obsproject.Studio.

flathubbot commented 2 years ago

Started test build 62170

flathubbot commented 2 years ago

Build 62170 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/60003/com.obsproject.Studio.flatpakref

GeorgesStavracas commented 2 years ago

Thanks, this generally looks good to me. I have two questions:

Do you know of any differences in behaviour between the KDE 5.15 platform and this?
Could you please apply the same changes to https://github.com/obsproject/obs-studio/blob/master/CI/flatpak/com.obsproject.Studio.json ? Feel free to open a pull request against the upstream obs-studio and I'll review it there too

GeorgesStavracas commented 2 years ago

I think this would also require updating plugins, and the documentation at https://github.com/flathub/com.obsproject.Studio/wiki/Plugins

tinywrkb commented 2 years ago

Do you know of any differences in behaviour between the KDE 5.15 platform and this?

It's KDE 5.15 but re-based on the Freedesktop 21.08 runtime, see this.
The only changes 21.08 that I took note of are:

python 3.9
added zstd and libglslang

tim77 commented 2 years ago

Do you know of any differences in behaviour between the KDE 5.15 platform and this?

This. Also nice to have some features like vulkan extensions, LTO. And new runtime is generally better supported.

Could you please apply the same changes to https://github.com/obsproject/obs-studio/blob/master/CI/flatpak/com.obsproject.Studio.json ? Feel free to open a pull request against the upstream obs-studio and I'll review it there too

Sure. Will do ASAP.

I think this would also require updating plugins

Oh, right, we should update them all as well. Currently there is three of them or i've missed some?

TiZ-HugLife commented 2 years ago

Thanks for the PRs against the plugins I maintain. Should I wait for this merge to take place before I merge the PRs on the plugins?

tim77 commented 2 years ago

Should I wait for this merge to take place before I merge the PRs on the plugins?

I guess better to wait a little bit. This need to be pushed and published altogether in Stable.

GeorgesStavracas commented 2 years ago

Hi, just passing by to say that I'm going to be a bit busy this week and will only have time for another round of reviews next week or later. My current concern with this PR is that the FreeDesktop 21.08 uses a newer glibc which uses clone3(), and there were reports that this is breaking Chromium. This is a problem for us because we enable the obs-browser plugin in the Flatpak, and this plugin uses CEF (Chromium Embedded Framework). If anyone could verify whether this issue affects us here, that would help a lot.

TiZ-HugLife commented 2 years ago

bot, build com.obsproject.Studio

flathubbot commented 2 years ago

Queued test build for com.obsproject.Studio.

flathubbot commented 2 years ago

Started test build 64466

TiZ-HugLife commented 2 years ago

Sorry for the noise and taking a while to get around to testing this out; my full-time job was kicking my butt! Once this build finishes, I'll give it a whack. :)

tim77 commented 2 years ago

I still have not enough time for testing Georges case even if i would like. Thank you @HugLifeTiZ

flathubbot commented 2 years ago

Build 64466 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/62294/com.obsproject.Studio.flatpakref

TiZ-HugLife commented 2 years ago

Okay, I gave it a test and it seems to be working. I have two browser docks and I added a browser source. @GeorgesStavracas, is there a specific way in which Chromium breaks, or is it a general crash?

GeorgesStavracas commented 2 years ago

IIRC it would fail to play videos and multimedia in general, and screencasts wouldn't start. The latter case is of course not relevant for OBS Studio, but I wonder if the former case is.

TiZ-HugLife commented 2 years ago

I think some stream widgets like alerts may make use of videos. I just tried out YouTube in the browser source and it works.

GeorgesStavracas commented 2 years ago

Great, thanks for testing that! I'll set aside some time tomorrow to land all of these pull requests in tandem, update the documentation and the plugin template, and take care of any eventual fallout from that.

GeorgesStavracas commented 2 years ago

I think I dealt with most of what's in here (currently only missing https://github.com/flathub/com.obsproject.Studio.Plugin.Gstreamer/pull/1 - can someone with merge permissions land that one please?)

Let's keep an eye for regressions