flathub / com.pokemmo.PokeMMO

https://flathub.org/apps/details/com.pokemmo.PokeMMO
1 stars 1 forks source link

Update glfw to 3.4 #17

Open Nevon opened 4 months ago

Nevon commented 4 months ago

Building from master fails with:

/usr/include/c++/13.2.0/string_view:258: constexpr const std::basic_string_view<_CharT, _Traits>::value_type& std::basic_string_view<_CharT, _Traits>::operator[](size_type) const [with _CharT = char; _Traits = std::char_traits<char>; const_reference = const char&; size_type = long unsigned int]: Assertion '__pos < this->_M_len' failed.
[34/116] Building C object src/CMakeFiles/glfw.dir/x11_window.c.o
ninja: build stopped: subcommand failed.
Error: module glfw: Child process exited with code 1

Updating to the 3.4 release of glfw builds just fine. See https://github.com/glfw/glfw/releases/tag/3.4

flathubbot commented 4 months ago

Started test build 129877

flathubbot commented 4 months ago

Build 129877 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/112854/com.pokemmo.PokeMMO.flatpakref
spazziale commented 4 months ago

@Nevon hi, thanks for the patch. I do not use and no longer have time to maintain this package, would you like to become a mantainer?

Nevon commented 4 months ago

Heh, I have enough people pinging me on GitHub already, so no thank you. 😅 I also don't really play this currently, so I don't have a need for it to be maintained. Do you have any contact with the upstream? Ideally you wouldn't need to maintain it separately from the upstream at all.