flathub / com.protonvpn.www

https://flathub.org/apps/details/com.protonvpn.www
10 stars 1 forks source link

(Temporary) Secret Service inaccessibility removes account authentication. #229

Closed RokeJulianLockhart closed 2 months ago

RokeJulianLockhart commented 2 months ago

When https://github.com/flathub/ch.protonmail.protonmail-bridge/issues/135#issue-2253012439 occurs, I am deauthenticated from my Proton account:

  1. Screenshot_20240501_145236 Screenshot_20240501_145502
  2. https://bugzilla.redhat.com/attachment.cgi?id=2027932&action=edit

I don't expect stored keys to be removed merely because the keychain store is unavailable.

proletarius101 commented 2 months ago

It looks mostly like an upstream issue and can only be addressed by the upstream: https://account.protonvpn.com/dashboard?chat=true

RokeJulianLockhart commented 2 months ago

https://github.com/flathub/com.protonvpn.www/issues/229#issuecomment-2088507906

@proletarius101, why do you believe that? I ask because although https://github.com/search?q=repo%3AProtonVPN%2Fproton-vpn-gtk-app%20secret&type=code demonstrates that most secret handling is performed by the upstream client's source code, https://github.com/search?q=repo%3Aflathub%2Fcom.protonvpn.www%20secret&type=code appears to demonstrate that Flatpak may well be controlling at least an aspect of this interaction.

Somewhat relevantly, in the same situation, the behaviour differs between this and https://github.com/flathub/ch.protonmail.protonmail-bridge/issues/136#issue-2273560688, where Bridge automatically requests that a new wallet be created, whereas this merely loses its authentication. https://github.com/flathub/com.bitwarden.desktop/tree/1a61a1840323f026228b6b87120c2f1007fd9652 doesn't appear to lose authentication in this situation.

proletarius101 commented 2 months ago

Flatpak only controls the permissions and the permission is set to "allowed".

You can confirm this by installing the DEB/RPM version from the upstream and see if the issue persists.

RokeJulianLockhart commented 2 months ago

https://github.com/flathub/com.protonvpn.www/issues/229#issuecomment-2088540983

@proletarius101, I don't know what causes the underlying issue yet, so I'll close this and report it upstream unless the RPMs don't exhibit it the next time it occurs.

RokeJulianLockhart commented 2 months ago

https://github.com/flathub/com.protonvpn.www/issues/229#issuecomment-2088563411

The upstream issue seems to be https://bugzilla.redhat.com/show_bug.cgi?id=2276060#c0 rather than anything Proton-specific, since Bitwarden exhibits the same behaviour:

Screenshot_20240503_161648