add support for flatpak in perform_downloader_desktop_integration

[eliadevito]

Hi @xarbit, This should fix https://github.com/flathub/com.prusa3d.PrusaSlicer/issues/81, if it work i will send a pull request upstream for merge

[flathubbot]

Started test build 62044

[flathubbot]

Build 62044 failed

[flathubbot]

Started test build 62045

[flathubbot]

Build 62045 failed

[xarbit]

for some reason the builds fail

[eliadevito]

seem related to recent upstream commits, tomorrow i investigate better and open an issue upstream

[flathubbot]

Started test build 62282

[eliadevito]

this commit should fix this build error

/run/build/PrusaSlicer/src/libslic3r/CutUtils.cpp: In member function ‘const ModelObjectPtrs& Slic3r::Cut::perform_with_plane()’:
/run/build/PrusaSlicer/src/libslic3r/CutUtils.cpp:300:23: error: ‘trace’ was not declared in this scope
  300 |     BOOST_LOG_TRIVIAL(trace) << "ModelObject::cut - start";
      |                       ^~~~~
/run/build/PrusaSlicer/src/libslic3r/CutUtils.cpp:300:5: error: ‘BOOST_LOG_TRIVIAL’ was not declared in this scope
  300 |     BOOST_LOG_TRIVIAL(trace) << "ModelObject::cut - start";
      |     ^~~~~~~~~~~~~~~~~

remain only the tbb error, now i’ll take a look

[flathubbot]

Build 62282 failed

[flathubbot]

Started test build 62288

[eliadevito]

ok the boost error is gone, try tbb fix :crossed_fingers:

[flathubbot]

Build 62288 failed

[flathubbot]

Started test build 62296

[eliadevito]

the x86_64 build seems OK, I sended upstream a PR to add missing includes, after tests (probably tomorrow) i will send another PR with the patch to fix printables desktop integration

[flathubbot]

Build 62296 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/44925/com.prusa3d.PrusaSlicer.flatpakref

[flathubbot]

Started test build 62307

[flathubbot]

Build 62307 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/44936/com.prusa3d.PrusaSlicer.flatpakref

[xarbit]

Hi @eliadevito Great job .. That's a bunch of patches needed ..

What do we do with this PR? Are you getting this upstreamed and we ignore or can I merge this?

Thanks!

[xarbit]

https://github.com/prusa3d/PrusaSlicer/pull/11218

[eliadevito]

Hi @eliadevito Great job .. That's a bunch of patches needed ..

What do we do with this PR? Are you getting this upstreamed and we ignore or can I merge this?

Thanks!

Hi @xarbit there is a minor change I have to made in the printable integration patch, after that, IMO we can merge this.

the patch mostly add missing includes, we can remove them after upstream merge

[eliadevito]

if you prefer i can squash the 3 patches that add missing includes into one

[xarbit]

That's fine, let's wait for your minor changes in the printable integration patch. We should also integrate the changes needed for the printables.com appurl mime type upstream.

[flathubbot]

Started test build 62599

[flathubbot]

Build 62599 failed

[flathubbot]

Started test build 62600

[flathubbot]

Build 62600 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/45234/com.prusa3d.PrusaSlicer.flatpakref

[flathubbot]

Started test build 62634

[eliadevito]

Hi @xarbit, we are ready, after finish this build can be pushed in beta.

I sended printables.com integration patch upstream (https://github.com/prusa3d/PrusaSlicer/pull/11229)

[flathubbot]

Build 62634 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/45268/com.prusa3d.PrusaSlicer.flatpakref