search

flathub / com.slack.Slack

https://flathub.org/apps/details/com.slack.Slack
35 stars 36 forks source link

Drop --filesystem=xdg-run/pipewire-0 from manifest #147

Closed rmader closed 7 months ago

rmader commented 2 years ago

The fact that screen sharing required Pipewire socked access despite using the xdg portal was a WebRTC bug. Once the fix has reached stable, --filesystem=xdg-run/pipewire-0 can be dropped.

WhyNotHugo commented 2 years ago

We'll need to wait for Electron to release a stable version with this, and then Slack update their binary release.

rmader commented 2 years ago

AFAIK the fix went into Chromium 96, which again is the base for Electron 16 from last November. Unfortunately Slack release notes don't contain Electron updates (they did - but I assume they are not on Electron 4.2.1 any more...). So it could be that this already works now, but needs testing.

razzeee commented 8 months ago

They seem to list versions at https://app.slack.com/libs/desktop now, and they are still at electron 15

Edit: Hrm, nevermind, I guess they never thought of updating that file?

ZVNexus commented 7 months ago

@razzeee Yeah they just don't update that page anymore, the current Electron version is v28.1.2 when looking inside the asar package, which released last week (https://github.com/electron/electron/releases/tag/v28.1.2). Nice to see they're keeping it up to date.