flathub / com.slack.Slack

https://flathub.org/apps/details/com.slack.Slack
34 stars 36 forks source link

Fix wayland detection in some systems #271

Closed pedrovanzella closed 4 months ago

pedrovanzella commented 4 months ago

Flatpak seems to be setting ${WAYLAND_DISPLAY} to an absolute path in some systems. This was causing the wayland check to fail because we were looking for the wrong path. This change should support all cases now.

flathubbot commented 4 months ago

Started test build 105368

flathubbot commented 4 months ago

Build 105368 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88172/com.slack.Slack.flatpakref
flathubbot commented 4 months ago

Started test build 105371

flathubbot commented 4 months ago

Build 105371 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88175/com.slack.Slack.flatpakref
ZVNexus commented 4 months ago

This breaks the Wayland opt in on Fedora 39 w/GNOME 45.4.

flathubbot commented 4 months ago

Started test build 105802

flathubbot commented 4 months ago

Build 105802 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88609/com.slack.Slack.flatpakref
flathubbot commented 4 months ago

Started test build 105803

flathubbot commented 4 months ago

Build 105803 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88610/com.slack.Slack.flatpakref
pedrovanzella commented 4 months ago

@ZVNexus thanks for testing! I've reverted the change that was probably causing the issue you had. I've tested the latest build locally (Arch, KDE 6) and it works for me. Can you check if it works for you as well?

mvdan commented 4 months ago

Thanks so much for this! Discord and Slack both stopped working on Wayland for me a few weeks ago on Arch, and after some digging, I came to the same conclusion as you. LGTM and it works for me!