search

flathub / com.spotify.Client

https://flathub.org/apps/details/com.spotify.Client
68 stars 34 forks source link

Add spotifywm to fix window class, icon, etc. #142

Closed TiZ-HugLife closed 3 years ago

TiZ-HugLife commented 3 years ago

Baby's first flathub contribution! (In case it's unclear, I'm baby.)

I thought that my first attempt at adding spotifywm was gonna fall flat on its face and I was gonna have to spend a couple hours fixing something, but it... just seems to work, exactly as I thought it would. I put the preload library in /app/lib, hope that's the right place semantically.

When I first tried to work on this, I struggled with the server not really cooperating with letting me download the base package but I was able to complete the build process today and test it, and it seems to be working as expected. This should fix #68, or at the very least, make it better. :)

flathubbot commented 3 years ago

Started test build 30890

flathubbot commented 3 years ago

Build 30890 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/29759/com.spotify.Client.flatpakref
TingPing commented 3 years ago

Looks OK, can you confirm the test build fixes all your issues?

flathubbot commented 3 years ago

Started test build 31147

TiZ-HugLife commented 3 years ago

For me, it does; window management automation tools like Devilspie2 would fail to detect Spotify's window about 60% of the time, but now they work consistently, as expected.

flathubbot commented 3 years ago

Build 31147 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/30007/com.spotify.Client.flatpakref
flathubbot commented 3 years ago

Started test build 31156

flathubbot commented 3 years ago

Build 31156 failed

TiZ-HugLife commented 3 years ago

Build 31156 failed

"Connection timed out" trying to connect to github??? Is there a way to ask the bot to try again?

TingPing commented 3 years ago

bot, build

flathubbot commented 3 years ago

Queued test build for com.spotify.Client.

flathubbot commented 3 years ago

Started test build 31177

flathubbot commented 3 years ago

Build 31177 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/30034/com.spotify.Client.flatpakref
flathubbot commented 3 years ago

Started test build 31193

flathubbot commented 3 years ago

Build 31193 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/30049/com.spotify.Client.flatpakref
sbstp commented 2 years ago

I'm still having this issue

TiZ-HugLife commented 2 years ago

First, this is very much the wrong place to report problems.

Second, SpotifyWM broke a loooooong time ago. In fact, window identification broke even worse in the most recent version of Spotify. Their engineers have not responded to the thread of issue reports related to it.