flathub / com.spotify.Client

https://flathub.org/apps/details/com.spotify.Client
74 stars 35 forks source link

The last build fails to apply extra data #176

Closed fariasmarcos closed 3 years ago

fariasmarcos commented 3 years ago

Since operations with extra-data aren't checked at build time, the build of #175 was successful, but the package fails to install.

Version: 1.1.68.632.g2b11de83 Distro: Fedora 34

TingPing commented 3 years ago

It did install here.. can you post logs?

fariasmarcos commented 3 years ago

Sure, the update command didn't say much tho... Also, my locale is pt_BR, so some of the messages are mixed with portuguese words:

 Calling system helper: GetRevokefsFd
F: Calling system helper: GetRevokefsFd
F: flatpak_dir_pull: Using commit 3926923c6dd06e8e6b07c18609313a3fe6a33d3430702c3f41abf138b909ff0d for pull of ref app/com.spotify.Client/x86_64/stable from remote flathub

Atualizando…                        0%  0 byte/s
Atualizando… █                      5%F: Loading https://api.snapcraft.io/api/v1/snaps/download/pOBIoZ2LrCB3rDohMxoYGnbN14EHOgD7_53.snap using libsoup
Atualizando… ████████████████████ 100%  5,7 MB/s  00:00F: Received 169922560 bytes
F: Calling system helper: Deploy
Erro: Error deploying: Enquanto tentava aplicar dados extras: script apply_extra falhou, status de saída 256
Atualização concluída.                                                                           
erro: Houve um ou mais erros

Basically it just says the script apply_extra failed to run and exited with code 256.

fariasmarcos commented 3 years ago

Ah, I just tried to install the build directly from the PR, and it gave me some more useful information!

Filesystem uses lzo compression, this is unsupported by this version
Decompressors available:
    gzip
    xz
mv: cannot stat 'squashfs-root/usr/bin/spotify': No such file or directory
mv: cannot stat 'squashfs-root/usr/share/spotify': No such file or directory
rm: cannot remove 'squashfs-root': No such file or directory

Looks like unsquashfs isn't working, maybe because lzop isn't available inside the build environment? I've downloaded the snap bundle on my host machine and I was able to extract it's contents with unsquashfs just fine.

nirfse commented 3 years ago

I get the same update error on ArchLinux, failing with "Filesystem uses lzo compression, this is unsupported by this version".

pratzyushd commented 3 years ago

I get the same error running Pop!_OS 21.04 when trying to install Spotify.

Filesystem uses lzo compression, this is unsupported by this version
Decompressors available:
  gzip
  xz
mv: cannot stat 'squashfs-root/usr/bin/spotify': No such file or directory
mv: cannot stat 'squashfs-root/usr/share/spotify': No such file or directory
rm: cannot remove 'squashfs-root': No such file or directory

Exactly this shows up.

stuarthayhurst commented 3 years ago

I ran flatpak install --user https://dl.flathub.org/build-repo/58231/com.spotify.Client.flatpakref a couple days ago to test something, and that installed fine. It should be the same build, shouldn't it? What changed? It's the link from the build in #175

pratzyushd commented 3 years ago

@stuarthayhurst Just tried that command, and it has the same issue. I think it's something to do with Ubuntu recently updating the Snap to using LZO compression. Maybe the Flatpak is based on the Snap and so is breaking?

stuarthayhurst commented 3 years ago

Whoops, must've been an earlier test build I used then. Looks like it was in #174 flatpak install --user https://dl.flathub.org/build-repo/57908/com.spotify.Client.flatpakref this one for for me when installing

stuarthayhurst commented 3 years ago

So is the repo just missing these commits? (2 different links)

pratzyushd commented 3 years ago

Whoops, must've been an earlier test build I used then. Looks like it was in #174 flatpak install --user https://dl.flathub.org/build-repo/57908/com.spotify.Client.flatpakref this one for for me when installing

This worked for me surprisingly.

stuarthayhurst commented 3 years ago

Yep, that should be because that build has the 2 missing commits to handle the LZO stuff

pratzyushd commented 3 years ago

So is the repo just missing these commits? (2 different links)

Possibly, I'm not sure and I'm not too experienced with this stuff.

pratzyushd commented 3 years ago

Yep, that should be because that build has the 2 missing commits to handle the LZO stuff

Ah brilliant, that explains it. Hopefully the dev resolves it soon