search

flathub / com.spotify.Client

https://flathub.org/apps/details/com.spotify.Client
74 stars 35 forks source link

Updated runtime to 21.08 and others #181

Closed samy-k97 closed 3 years ago

samy-k97 commented 3 years ago

Also:

flathubbot commented 3 years ago

Started test build 61387

flathubbot commented 3 years ago

Build 61387 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/59221/com.spotify.Client.flatpakref
lionirdeadman commented 3 years ago

Does that ffmpeg work? I remember ffmpeg being left old because Spotify wouldn't work otherwise.

And if it does, does 4.4 work?

samy-k97 commented 3 years ago

I haven't noticed any difference when testing it. If needed I can revert back to the version it was using

samy-k97 commented 3 years ago

I've just tested with ffmpeg 4.4 and music seems to be playing fine. I can push this change if you want

lionirdeadman commented 3 years ago

I don't use Spotify but I believe ffmpeg is used for local music play, not online play if you could test that?

flathubbot commented 3 years ago

Started test build 61399

flathubbot commented 3 years ago

Build 61399 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/59233/com.spotify.Client.flatpakref
samy-k97 commented 3 years ago

I've played a few m4a and mp3 files and it seems fine. No issues for now

TingPing commented 3 years ago

Just out of curiosity, if you delete ffmpeg do local files work for you?

samy-k97 commented 3 years ago

Yes, everything works fine without ffmpeg

Erick555 commented 3 years ago

I think spotify gained support for ffmpeg 4.x some time ago so we may potentially remove bundled ffmpeg then use it from runtime + ffmpeg-full extension although we need to check if runtime update it too far in future.

TingPing commented 3 years ago

Lets just remove the bundled ffmpeg for now then.

flathubbot commented 3 years ago

Started test build 61471

flathubbot commented 3 years ago

Build 61471 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/59304/com.spotify.Client.flatpakref