search

flathub / com.spotify.Client

https://flathub.org/apps/details/com.spotify.Client
74 stars 35 forks source link

Fix title bar coming up empty #188

Closed msdrigg closed 2 years ago

msdrigg commented 2 years ago

For some reason, when the icons folder is missing, the title bar comes up empty.

I don't know why, but this fixes the issue.

This resolves #184

Edit: I think this also resolves #180 and #179. I didn't mention them previously because I didn't notice them before I made the change.

flathubbot commented 2 years ago

Started test build 69283

msdrigg commented 2 years ago

I have tested this on my computer using the command 

flatpak-builder --user --install --force-clean build-dir com.spotify.Client.json

If any further testing would be helpful, ping me

flathubbot commented 2 years ago

Build 69283 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/67120/com.spotify.Client.flatpakref
msdrigg commented 2 years ago

I also tested with the flathubbot link above. I tested by playing music and verified that the title bar now displays correctly.

jvnknvlgl commented 2 years ago

I can confirm that this change fixes the title bar for me as well. The window also isn't launched in the top left corner anymore, so the behavior is the same as it was previously.

Screenshot from 2021-12-02 20-22-14

Erick555 commented 2 years ago

Nice find, thx! @TingPing this should fix many reported issues so please merge when you find the time.

@msdrigg I think you can mark https://github.com/flathub/com.spotify.Client/issues/180 and https://github.com/flathub/com.spotify.Client/issues/179 as fixed too in description

TomiOhl commented 2 years ago

Excellent job guys 😍

Btw at least 2 additional issues may be closed now (179 and 169)

aamadis commented 2 years ago

I had the same problem of the proper icon not showing up in the toolbar. I just uninstalled and reinstalled the flatpak version. flatpak list now shows that I am running Spotify version 1.1.72.439.gc253025e, but the problem remains and now full-screen does not work in Spotify. Is this the same problem or something different? Any help appreciated.

msdrigg commented 2 years ago

@aamadis That sounds like something different. Maybe this: https://github.com/flathub/com.spotify.Client/issues/179

aamadis commented 2 years ago

But didn't this new fix close issue #179?

msdrigg commented 2 years ago

Well I thought it did, but if you are still experiencing it, then it must not be fixed. What os/desktop are you running? I saw people were having trouble with Fedora and KDE. I don't see this issue on pop-os (ubuntu based) and gnome.

aamadis commented 2 years ago

Installed on 2 computers Ubuntu Budgie (20.04) and Ubuntu Gnome Flashback (16.04). Same problem on both.

aamadis commented 2 years ago

Info that may or may not be helpful: I still have an older version of Spotify on the gnome flashback computer. Not sure of the version, but it's in my usr/share folder. That version has the same icon problem, but when I change the window to full-screen, the correct icon is displayed until the next time I open Spotify.

msdrigg commented 2 years ago

I think it would be best to open another issue describing the problem and listing your configuration. I don't know an easy fix for this now, but this is certainly weird behavior.

If this issue also happens with the plain .deb published by spotify, then this might not even be an issue with flatpak at all

aamadis commented 2 years ago

Will do. Thanks for your time and help.