search

flathub / com.spotify.Client

https://flathub.org/apps/details/com.spotify.Client
68 stars 34 forks source link

_GTK_THEME_VARIANT xprop ignored on Fedora 38 #238

Open subpop opened 1 year ago

subpop commented 1 year ago

It looks like the xprop _GTK_THEME_VARIANT is ignored by clients on Fedora 38. I've verified that the property _GTK_THEME_VARIANT is set to dark:

[link@localhost ~]$ xprop -name Spotify | grep GTK_THEME
_GTK_THEME_VARIANT(UTF8_STRING) = "dark"

But the window title bar is still light.

TingPing commented 1 year ago

To be clear, that means its ignored by the window manager and/or the window manager doesn't have a GTK3 theme with that variant.

This is somewhat investigated in https://github.com/flathub/com.spotify.Client/issues/236

I'm not sure what this package can do about it.

subpop commented 1 year ago

I'm not clear where the issue exists. If the xprop is a hint to the window manager, is it mutter that's ignoring the hint and not setting the variant?

TingPing commented 1 year ago

It is handled in mutter.

TingPing commented 1 year ago

I think GNOME-Shell just no longer uses GTK3: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2655