search

flathub / com.spotify.Client

https://flathub.org/apps/details/com.spotify.Client
68 stars 34 forks source link

Convert to yaml #252

Closed eclipseo closed 9 months ago

eclipseo commented 9 months ago

For reference, https://blogs.gnome.org/alexl/2018/05/04/yamling-the-flathub/

Why do I suggest this: cause it easier to copy paste some stuff from other flatpak, and most of them are in YAML already.

flathubbot commented 9 months ago

Started test build 68145

flathubbot commented 9 months ago

Build 68145 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/50796/com.spotify.Client.flatpakref
Erick555 commented 9 months ago

It break all git history though. How often would you need to copy something here?

eclipseo commented 9 months ago

It break all git history though. How often would you need to copy something here?

How does it break all GIT history? It is still there.

Erick555 commented 9 months ago

Like this. it's hard to find from which commit particular code origins.

eclipseo commented 9 months ago

Like this. it's hard to find from which commit particular code origins.

Yes but you can still access the blame of com.spotify.Client.json in the GIT history. Since this is the first commit of this file, there is only one blame.

Erick555 commented 9 months ago

Why making things more difficult than they are though? json is same valid as yaml on flathub and it worked fine for past 5 years.

TingPing commented 9 months ago

I'm not necessarily against this, but you are opening a lot of PRs at once. So can we start with your other small changes and we can think about this later?

TingPing commented 9 months ago

Lets just keep it as is for now.