search

flathub / com.spotify.Client

https://flathub.org/apps/details/com.spotify.Client
74 stars 34 forks source link

Update spotify.snap to 1.2.22.982.g794acc0a #260

Closed slagiewka closed 11 months ago

slagiewka commented 11 months ago

This PR takes the commit from #259 and cherry-picks https://github.com/eclipseo/com.spotify.Client/commit/f0b705d509a3ab863d9da3c8c20da253c88d8014 with removed references to beta/edge - leaving what's (most likely) necessary to get the appindicator support.

The build from flathubbot now works for me. I can also tell that the MPRIS support on Wayland must be much better - I've tested this with KDE Connect's "Pause media during calls". It works wonders - pauses Spotify when the call is incoming and starts it back again when the call is finished.

flathubbot commented 11 months ago

Started test build 75574

flathubbot commented 11 months ago

Build 75574 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/58214/com.spotify.Client.flatpakref
slagiewka commented 11 months ago

One thing that is not great - Spotify "tray" seems to show. But not as other icons in the "always visible" - it hides in the pop out menu.

image

flathubbot commented 11 months ago

Started test build 76093

flathubbot commented 11 months ago

Build 76093 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/58676/com.spotify.Client.flatpakref
slagiewka commented 11 months ago

It's not your fault but please remove "branch": "stable", from the manifest since this blocks installing test PR alongside stable app.

Do you mean installing it locally (as per the test build output)? Actually I didn't find it annoying when the stable is installed and test is installed with --user. I just have to uninstall (with --user) when I want to install another build.

Also please add require-important-update: true in flathub.json and is-main-source: true into spotify x-checker metadata in order to prevent re-downloading whole spotify when some minor dep bumps version.

This and the above suggestion seem like they should be done outside of this PR. And I personally wouldn't volunteer to touch these (at least not right now).

Erick555 commented 11 months ago

Do you mean installing it locally (as per the test build output)? Actually I didn't find it annoying when the stable is installed and test is installed with --user. I just have to uninstall (with --user) when I want to install another build.

What if stable is installed as --user as well? You need to remove it first to test anything.

This and the above suggestion seem like they should be done outside of this PR. And I personally wouldn't volunteer to touch these (at least not right now).

Every update will trigger full re-download of spotify by all users even when there aren't functional changes. For this reason I think it's better to avoid splitting minor changes to separate updates.

Erick555 commented 11 months ago

I made https://github.com/flathub/com.spotify.Client/pull/261 to speed-up things.