search

flathub / com.stepmania.StepMania

https://flathub.org/apps/details/com.stepmania.StepMania
3 stars 3 forks source link

Build stepmania with ffmpeg support #10

Closed izissise closed 4 years ago

izissise commented 4 years ago

We need to use make and not ninja because stepmania's ffmpeg can't be build with ninja

https://github.com/stepmania/stepmania/blob/5_1-new/CMake/SetupFfmpeg.cmake#L1

Also add network access during build so cmake can automatically download the correct version through git

https://github.com/stepmania/stepmania/blob/5_1-new/CMake/SetupFfmpeg.cmake#L86

This would fix #8

flathubbot commented 4 years ago

Started test build 18681

flathubbot commented 4 years ago

Build 18681 failed

FakeShemp commented 4 years ago

Building with network access won't work. You will have to get ffmpeg added before the build is started somehow.

I'm not sure if this can be done with just downloading the files or if it needs a patch of some sort.

izissise commented 4 years ago

Ah too bad the CI machine enforce the sandbox. I think it can be done, the SetupFfmpeg file allow to define a variable where ffmpeg sources should reside https://github.com/stepmania/stepmania/blob/5_1-new/CMake/SetupFfmpeg.cmake#L62

But I've been trying to make it work that way for a little over than a day, so I give up for now

flathubbot commented 4 years ago

Started test build 18971

izissise commented 4 years ago

This should work now :)

flathubbot commented 4 years ago

Build 18971 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/18183/com.stepmania.StepMania.flatpakref
flathubbot commented 4 years ago

Started test build 18973

flathubbot commented 4 years ago

Build 18973 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/18185/com.stepmania.StepMania.flatpakref
FakeShemp commented 4 years ago

Seem to work. Good job :+1: