flathub / com.sublimetext.three

https://flathub.org/apps/details/com.sublimetext.three
6 stars 4 forks source link

Some improvements #15

Closed gasinvein closed 4 years ago

gasinvein commented 4 years ago

Some of this changes might be subjective, so it's ok to reject it if you disagree.

flathubbot commented 4 years ago

Started test build 13134

flathubbot commented 4 years ago

Build 13134 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12533/com.sublimetext.three.flatpakref
flathubbot commented 4 years ago

Started test build 13135

flathubbot commented 4 years ago

Build 13135 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12534/com.sublimetext.three.flatpakref
flathubbot commented 4 years ago

Started test build 13136

flathubbot commented 4 years ago

Build 13136 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12535/com.sublimetext.three.flatpakref
ptomato commented 4 years ago

Thank you! Sorry I won't have a chance to take a detailed look at these until next week but I'll try to get to it as soon as possible.

gasinvein commented 4 years ago

The Sublime Merge extension is to be created and submitted to Flathub. It shouldn't be difficult, though.

flathubbot commented 4 years ago

Started test build 14154

flathubbot commented 4 years ago

Build 14154 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/13508/com.sublimetext.three.flatpakref
ptomato commented 4 years ago

OK, thanks, this is great! I'm happy to leave the Sublime Merge extension point as a future open improvement. I would like to make sure there is an updated DevUtils extension before merging it though, otherwise people's installations will break when they update.

ptomato commented 4 years ago

Unfortunately I've discovered while updating the DevUtils that it's not possible to build Node 12.x with Python 3, and the new freedesktop runtime doesn't have Python 2. I wonder if we should hold off on moving to the new runtime until the next Node LTS is out later this year.

gasinvein commented 4 years ago

Unfortunately I've discovered while updating the DevUtils that it's not possible to build Node 12.x with Python 3, and the new freedesktop runtime doesn't have Python 2.

Why not just put python 2 into the extension bundle? org.freedesktop.Sdk.Extension.node10 does so.

refi64 commented 4 years ago

@ptomato Someone added a node12 extension, maybe try that?

ptomato commented 4 years ago

OK, thanks, will try that.

bot, build com.sublimetext.three

flathubbot commented 4 years ago

Queued test build for com.sublimetext.three.

flathubbot commented 4 years ago

Started test build 16903

flathubbot commented 4 years ago

Build 16903 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/16179/com.sublimetext.three.flatpakref