search

flathub / com.sublimetext.three

https://flathub.org/apps/details/com.sublimetext.three
6 stars 4 forks source link

Patch to work with freedesktop 18.08 #3

Closed Othko97 closed 5 years ago

Othko97 commented 6 years ago

Freedesktop 18.08 works with multi-arch, so libraries are split out, and libbfd has moved. This patch updates the copying of libbfd to the new multi-arch system.

Obviously don't merge until freedesktop released as stable

Note: This is not backwards compatible with 1.6 as /usr/lib/{multiarch-triple}/libbfd.so doesn't exist in 1.6

ptomato commented 6 years ago

Thanks, this looks like it makes sense, replacing unstable with 18.07 when the runtime is released. Ping me when it should be merged...

Othko97 commented 6 years ago

Yeah we need my patch for electron to be merged first, but I don't think the maintainers have decided how to handle the upgrade yet to keep the 1.6 version available too

TingPing commented 6 years ago

Yeah we need my patch for electron to be merged first, but I don't think the maintainers have decided how to handle the upgrade yet to keep the 1.6 version available too

We have a plan, manually hardcode it in the buildbot... It sucks but I'll try to remember to do it this weekend.

TingPing commented 6 years ago

The baseapp landed.

ptomato commented 5 years ago

The next release of Sublime Text will use GTK3 anyway, so hopefully the base app should not be needed for GTK2 in the future.

ptomato commented 5 years ago

I had to do some other maintenance and update the DevUtils extension at the same time, so I've ported your commit to my branch. (The whole libbfd thing is no longer necessary, so we can drop that commit.) I'll close this merge request and merge my branch manually. Thanks for looking into this!