flathub / com.sweethome3d.Sweethome3d

https://flathub.org/apps/details/com.sweethome3d.Sweethome3d
3 stars 3 forks source link

SH3D plugins: Network access permissions are needed #40

Open pabloab opened 1 year ago

pabloab commented 1 year ago

As mentioned on this SH3D bug, right now some issues arises while trying to run plugins if they try to access to internet. UnknownHostException and error message dialogs. It is possible to fix this with Flatseal or on terminal.

flatpak override --user --share=network com.sweethome3d.Sweethome3d  # Grant network access to SH3D
flatpak override --user --show com.sweethome3d.Sweethome3d           # Show override granted permissions
flatpak info --show-permissions com.sweethome3d.Sweethome3d          # Show all granted permissions

Would be just to add a --share=network on this json?

hadess commented 1 year ago

As network access isn't required by the stock SweetHome3D, I'm not too interested in adding network access that won't be used at all. From what I undestand in https://sourceforge.net/p/sweethome3d/bugs/1177/, the newer version of the plugin should show a real error message.

pabloab commented 1 year ago

SH3D does not require Internet access on the desktop version, but use it if it's available. From bug 1177 (Emmanuel Puybaret is the main maintainer):

Sweet Home 3D uses Internet access to check new versions when Check updates at program launch option is selected in the preferences. If Internet access is not granted, this check will be simply ignored.

I wonder if Flatpak could rise a dialog asking the user for the permission on that particular session, just like running OpenSnitch. That would be a nice middle ground.

hadess commented 1 year ago

SH3D does not require Internet access on the desktop version, but use it if it's available. From bug 1177 (Emmanuel Puybaret is the main maintainer):

Sweet Home 3D uses Internet access to check new versions when Check updates at program launch option is selected in the preferences. If Internet access is not granted, this check will be simply ignored.

Which means we would need to disable that functionality if we enabled networking.

I wonder if Flatpak could rise a dialog asking the user for the permission on that particular session, just like running OpenSnitch. That would be a nice middle ground.

This would require a proxy running on the host to filter network connections, it's not trivial: https://github.com/flatpak/flatpak/issues/3054

pabloab commented 1 year ago

Sweet Home 3D uses Internet access to check new versions

Which means we would need to disable that functionality if we enabled networking.

Just check for new versions, does not update itself.

Considering SH3D and its plugins could check if they are running inside a flatpak, and could therefore point to fix it granting network access (for the time being, via Flatseal or CLI), I believe this issue could be closed.

This would require a proxy running on the host to filter network connections, it's not trivial: flatpak/flatpak#3054

Hope to see this one day.