flathub / com.synology.SynologyDrive

https://flathub.org/apps/details/com.synology.SynologyDrive
7 stars 10 forks source link

Drop org.kde.* own-name #37

Open bbhtt opened 1 year ago

bbhtt commented 1 year ago

This is no longer required with any supported runtimes

https://docs.flatpak.org/en/latest/desktop-integration.html#statusnotifier

Most implementations of StatusNotifer have dropped this requirement

https://github.com/flathub/flatpak-builder-lint/issues/ 66#issuecomment-1386033025

flathubbot commented 1 year ago

Started test build 69338

flathubbot commented 1 year ago

Build 69338 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/51992/com.synology.SynologyDrive.flatpakref
bbhtt commented 1 year ago

I don't have a login for this, so this needs testing. There's no settings/tray without crossing the login.

lil5 commented 1 year ago

I remember keeping it in there just in case as testing each option takes lots of time, I’ll give it a go sometime this weekend/ next week

bbhtt commented 9 months ago

I remember keeping it in there just in case as testing each option takes lots of time, I’ll give it a go sometime this weekend/ next week

This will now be blocked through the linter https://docs.flathub.org/docs/for-app-authors/linter. Did you get a chance?

flathubbot commented 9 months ago

Started test build 91215

flathubbot commented 9 months ago

Build 91215 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73894/com.synology.SynologyDrive.flatpakref
flathubbot commented 7 months ago

Started test build 98500

flathubbot commented 7 months ago

Build 98500 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/81279/com.synology.SynologyDrive.flatpakref
faeb5 commented 7 months ago

I test this today, unfortunately it does not seem to work. No status icon for me, which seems to be confirmed by this exception: failed to register service "org.kde.StatusNotifierItem-7-1"

lil5 commented 7 months ago

@faeb5 Thanks for the comment

Could attempt --talk=org.kde.StatusNotifierItem-$PID-$ITEM_ID this should satisfy the new linter rules too.

bbhtt commented 7 months ago

Exceptions in case of legacy tray usage are accepted see https://docs.flathub.org/docs/for-app-authors/linter/#finish-args-wildcard-name-own-name

The process is explained at the bottom of the page.

Could attempt --talk=org.kde.StatusNotifierItem-$PID-$ITEM_ID this should satisfy the new linter rules too.

That won't work.

faeb5 commented 7 months ago

Thanks @bbhtt , I created a MR over at flathub-infra/flatpak-builder-lint#283 which adds the exception for the Synology Client.

lil5 commented 4 months ago

@faeb5 So if i understand correctly I can close this Under wontfix correct?