Open bbhtt opened 1 year ago
Started test build 69338
Build 69338 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/51992/com.synology.SynologyDrive.flatpakref
I don't have a login for this, so this needs testing. There's no settings/tray without crossing the login.
I remember keeping it in there just in case as testing each option takes lots of time, I’ll give it a go sometime this weekend/ next week
I remember keeping it in there just in case as testing each option takes lots of time, I’ll give it a go sometime this weekend/ next week
This will now be blocked through the linter https://docs.flathub.org/docs/for-app-authors/linter. Did you get a chance?
Started test build 91215
Build 91215 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/73894/com.synology.SynologyDrive.flatpakref
Started test build 98500
Build 98500 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/81279/com.synology.SynologyDrive.flatpakref
I test this today, unfortunately it does not seem to work. No status icon for me, which seems to be confirmed by this exception: failed to register service "org.kde.StatusNotifierItem-7-1"
@faeb5 Thanks for the comment
Could attempt --talk=org.kde.StatusNotifierItem-$PID-$ITEM_ID
this should satisfy the new linter rules too.
Exceptions in case of legacy tray usage are accepted see https://docs.flathub.org/docs/for-app-authors/linter/#finish-args-wildcard-name-own-name
The process is explained at the bottom of the page.
Could attempt --talk=org.kde.StatusNotifierItem-$PID-$ITEM_ID this should satisfy the new linter rules too.
That won't work.
Thanks @bbhtt , I created a MR over at flathub-infra/flatpak-builder-lint#283 which adds the exception for the Synology Client.
@faeb5 So if i understand correctly I can close this Under wontfix correct?
This is no longer required with any supported runtimes
https://docs.flatpak.org/en/latest/desktop-integration.html#statusnotifier
https://github.com/flathub/flatpak-builder-lint/issues/ 66#issuecomment-1386033025