search

flathub / com.syntevo.SmartGit

https://flathub.org/apps/details/com.syntevo.SmartGit
3 stars 3 forks source link

Use openssh from runtime #24

Closed Erick555 closed 4 years ago

Erick555 commented 4 years ago

openssh is available in runtime since freedesktop 19.08 and there is no need to bundle it.

flathubbot commented 4 years ago

Started test build 9569

flathubbot commented 4 years ago

Build 9569 failed

Erick555 commented 4 years ago

bot, build

flathubbot commented 4 years ago

Queued test build for com.syntevo.SmartGit.

flathubbot commented 4 years ago

Started test build 9571

flathubbot commented 4 years ago

Build 9571 failed

Erick555 commented 4 years ago

it seems flathub has some issues right now, I'll try build it later.

Erick555 commented 4 years ago

bot, build

flathubbot commented 4 years ago

Queued test build for com.syntevo.SmartGit.

Erick555 commented 4 years ago

bot, build

flathubbot commented 4 years ago

Queued test build for com.syntevo.SmartGit.

x80486 commented 4 years ago

It would be great if that works...I didn't know OpenSSH was present already with Freedesktop 19.08 (I hope it doesn't get deleted).

Another improvement for this Flatpak would be to change the runtime to org.freedesktop.Sdk and also use the provided Git :sunglasses:

x80486 commented 4 years ago

bot, build

flathubbot commented 4 years ago

Queued test build for com.syntevo.SmartGit.

flathubbot commented 4 years ago

Started test build 9593

flathubbot commented 4 years ago

Build 9593 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/9096/com.syntevo.SmartGit.flatpakref
flathubbot commented 4 years ago

Started test build 9600

flathubbot commented 4 years ago

Build 9600 failed

flathubbot commented 4 years ago

Started test build 9601

flathubbot commented 4 years ago

Build 9601 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/9103/com.syntevo.SmartGit.flatpakref
Erick555 commented 4 years ago

Another improvement for this Flatpak would be to change the runtime to org.freedesktop.Sdk and also use the provided Git

This is not really recommended and supported use-case so I would stay with bundled git. Unfortunately it's little too big to add it to Platform

x80486 commented 4 years ago

I made the changes and it works fine. Why is it not recommended? Git is used in such way in almost every (JetBrains) Flatpak IDE.

What's the difference between the available git and ssh that one can used and the other not?

Erick555 commented 4 years ago

I made the changes and it works fine. Why is it not recommended? Git is used in such way in almost every (JetBrains) Flatpak IDE.

What's the difference between the available git and ssh that one can used and the other not?

@x80486 I meant using Sdk as runtime. For copying files from Sdk I have no opinion but you may try making symlinks instead.

Erick555 commented 4 years ago

Obviously symlinks can work only for openssh as git isn't available in Platform.