search

flathub / com.tutanota.Tutanota

https://flathub.org/apps/details/com.tutanota.Tutanota
12 stars 10 forks source link

Re-write of the existing manifest from JSON to yaml #150

Closed olof-nord closed 9 months ago

olof-nord commented 9 months ago

Some minor tweaks done on the way such as simplified archive handling and moving the executable file away from the flatpak lib folder.

The TMPDIR finish arg is also removed, as I didnt see it used anywhere.

A small Makefile is added for simpler usage of flatpak and flatpak-builder when developing.

Finally, the gitignore is trimmed to exclude temporary flatpak build files.

flathubbot commented 9 months ago

Started test build 87651

flathubbot commented 9 months ago

Build 87651 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/70318/com.tutanota.Tutanota.flatpakref
charlag commented 9 months ago

I'm not a fan of YAML but it has comments! Shouldn't it remove the .json file then?

It is a bit hard to review minor tweaks when it's mixed in with other changes though.

olof-nord commented 9 months ago

@charlag I see what you mean. Ill split this up into two: one which does the json to yaml and a second one which continues iterating on the manifest.

Ill use the flatpak json to yaml first to convert (and delete the old), and in a followup PR my further proposals.

olof-nord commented 9 months ago

Closing this PR as discussed: this will be done in smaller chunks instead. For the first change, see https://github.com/flathub/com.tutanota.Tutanota/pull/152.