search

flathub / com.tutanota.Tutanota

https://flathub.org/apps/details/com.tutanota.Tutanota
12 stars 10 forks source link

Address Electron system dbus error #165

Closed olof-nord closed 4 months ago

olof-nord commented 8 months ago

When starting the flatpak app, the following error is listed in the console:

[2:0106/161152.261636:ERROR:bus.cc(399)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory

This is because Chrome / Electron during startup by default tries to access the credential wallet per dbus. Adding this configuration avoids this failure.

https://www.freedesktop.org/software/systemd/man/latest/org.freedesktop.login1.html

flathubbot commented 8 months ago

Started test build 91881

flathubbot commented 8 months ago

Build 91881 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74572/com.tutanota.Tutanota.flatpakref
charlag commented 8 months ago

The error is harmless though?

olof-nord commented 8 months ago

The error is harmless though?

Valid point - with https://github.com/flathub/com.tutanota.Tutanota/issues/141 as the elephant in the room I propose to put this change in place as to avoid unneccesary noise when trying to understand what is missing for offering a fully functioning Tutanota app Flatpak.

Do you see any problems in this?

olof-nord commented 8 months ago

As an alternative solution, we could document that this configuration is needed to silence the errors for example. I am curious to what problems you are worried this might cause though?

Here a piece from the flatpak documentation on d-bus:

Talk permissions can be freely used, although it is recommended to use the minimum required.

https://docs.flatpak.org/en/latest/sandbox-permissions.html#d-bus-access

olof-nord commented 7 months ago

@ganthern / @charlag - Is this project open to contributors or more seen as an internal project?

flathubbot commented 7 months ago

Started test build 95374

flathubbot commented 7 months ago

Build 95374 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/78122/com.tutanota.Tutanota.flatpakref
charlag commented 7 months ago

@olof-nord which one do you mean?

olof-nord commented 4 months ago

Closing this PR as I understand this is more of an internal project - feel free to use this code in the future if you want to avoid this error.