search

flathub / com.tutanota.Tutanota

https://flathub.org/apps/details/com.tutanota.Tutanota
12 stars 10 forks source link

Allow window bar to adhere to dark/light mode #166

Closed olof-nord closed 4 months ago

olof-nord commented 8 months ago

The Electron/Wayland support is not supporting switching the window bar from light to dark without huge hacks (https://github.com/flathub/com.spotify.Client/blob/master/set-dark-theme-variant.py).

I propose to instead remove the ozone platform hint for now until the Chromium / Electron Wayland support is more mature. This runs Electron with X11.

This is unfortunately the case for many Electron based Flatpaks at the moment, see for example the note here

This closes https://github.com/flathub/com.tutanota.Tutanota/issues/151

tutanota-with-dark-titlebar

flathubbot commented 8 months ago

Started test build 91883

flathubbot commented 8 months ago

Build 91883 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74574/com.tutanota.Tutanota.flatpakref
olof-nord commented 8 months ago

See https://gitlab.com/olof-nord/flatpak-electron-dark-mode-demo for a more in-depth explanation as well as a separate proof of concept of a Flatpak app built with electron and electron-builder.

olof-nord commented 4 months ago

Closing this PR as I understand this is more of an internal project - feel free to use this code in the future if you want to address this problem.