flathub / com.usebruno.Bruno

https://flathub.org/apps/details/com.usebruno.Bruno
1 stars 8 forks source link

Update license to valid SPDX license identifier for MIT #16

Closed pietrygamat closed 5 months ago

pietrygamat commented 6 months ago

Flathub entry for bruno has invalid license id. Screenshot from 2024-05-07 23-03-25

The open source bruno is released under MIT, and not LicenseRef-MIT-, the entry may be ehnanced with very much inviting Screenshot from 2024-05-07 23-05-16 with a link to the project website and everything.

If I am wrong, however, and the project does not pass the criteria for relase under MIT, reject this PR, but please update the license to valid proprietary license id with url provided:. E.g.

<project_license>LicenseRef-proprietary=https://usebruno.com/license</project_license>

Resulting displaying correct value without halftruth about non-existend license: Screenshot from 2024-05-07 23-08-08

resolves #1

flathubbot commented 6 months ago

Started test build 114842

flathubbot commented 6 months ago

Build 114842 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/97656/com.usebruno.Bruno.flatpakref
flathubbot commented 5 months ago

Started test build 119540

flathubbot commented 5 months ago

Build 119540 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102387/com.usebruno.Bruno.flatpakref
flathubbot commented 5 months ago

Started test build 119797

flathubbot commented 5 months ago

Build 119797 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102651/com.usebruno.Bruno.flatpakref
AligningEntropy commented 3 months ago

This appears to have been reverted in Release 1.18.0 #22 and is back to showing the proprietary license badge. If the goal is to have a dual license as the flatpak description

Majority of our features are free and have been opensourced under the MIT license

AND this commit indicate.

Then this license should utilize the expression operators such as AND. This would result in the license being something like <project_license>MIT AND LicenseRef-proprietary=https://usebruno.com/license</project_license> (I could not find where the actual proprietary license was located to update the link to, so that would need adjustment once identified)

If not, then this change needs to be re-applied such that the license tag is once again <project_license>MIT</project_license>