flathub / com.valvesoftware.Steam.CompatibilityTool.Proton-GE

https://flathub.org/apps/details/com.valvesoftware.Steam.CompatibilityTool.Proton-GE
50 stars 5 forks source link

Update proton-ge-custom-src.tar.xz to 7.37-1 #119

Closed flathubbot closed 2 years ago

flathubbot commented 2 years ago

🤖 This pull request was automatically generated by flathub/flatpak-external-data-checker. Please open an issue if you have any questions or complaints. 🤖

flathubbot commented 2 years ago

Started test build 114097

flathubbot commented 2 years ago

Build 114097 failed

gasinvein commented 2 years ago

f-e-d-c check fails (Error substituting template: 'parent_major'):

INFO    src.manifest: Started check [28/30] archive wine-mono-bin/wine-mono-7.3.1-x86.tar.xz (from com.valvesoftware.Steam.CompatibilityTool.Proton-GE.yml)
ERROR   src.manifest: Failed to check archive wine-mono-bin/wine-mono-7.3.1-x86.tar.xz with HTMLChecker: Error substituting template: 'parent_major'
INFO    src.manifest: Started check [29/30] file wine-gecko-bin/wine-gecko-2.47.3-x86.tar.xz (from com.valvesoftware.Steam.CompatibilityTool.Proton-GE.yml)
ERROR   src.manifest: Failed to check file wine-gecko-bin/wine-gecko-2.47.3-x86.tar.xz with HTMLChecker: Error substituting template: 'parent_major'
INFO    src.manifest: Started check [30/30] file wine-gecko-bin/wine-gecko-2.47.3-x86_64.tar.xz (from com.valvesoftware.Steam.CompatibilityTool.Proton-GE.yml)
ERROR   src.manifest: Failed to check file wine-gecko-bin/wine-gecko-2.47.3-x86_64.tar.xz with HTMLChecker: Error substituting template: 'parent_major'
WARNING src.main: Check finished with 3 error(s)

Here, f-e-d-c runs against an up-to-date manifest, so there is no new version for the Proton-GE source, but without a new version (an no ability to determine the current one), it's has nothing to put into child sources check urls.

Lctrs commented 2 years ago

Do you think it's something that should be fixed/improved on fedc side ? It seems to work well with git checker.

gasinvein commented 2 years ago

Do you think it's something that should be fixed/improved on fedc side ?

It would be a sensible improvement to f-e-d-c (don't mind filing an issue, btw?), but the way to achieve it isn't clear to me right away.

It seems to work well with git checker.

It works for git checker because the parent source git tag is known from the manifest, unlike parent archive/file version.

Lctrs commented 2 years ago

@gasinvein see https://github.com/flathub/flatpak-external-data-checker/issues/330