flathub / com.valvesoftware.Steam.Utility.protontricks

This repo is archived by Flathub as the app is EOL. If this was done in error, please open an issue at https://github.com/flathub/flathub/issues
https://flathub.org/apps/details/com.valvesoftware.Steam.Utility.protontricks
23 stars 2 forks source link

Update to 1.5.0 #25

Closed Matoking closed 3 years ago

flathubbot commented 3 years ago

Started test build 44600

flathubbot commented 3 years ago

Build 44600 failed

flathubbot commented 3 years ago

Started test build 44602

flathubbot commented 3 years ago

Build 44602 failed

flathubbot commented 3 years ago

Started test build 44610

flathubbot commented 3 years ago

Build 44610 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42914/com.valvesoftware.Steam.Utility.protontricks.flatpakref
gasinvein commented 3 years ago

Hm, maybe detect flatpak sandbox at run time instead of adding a downstream patch? A check like os.path.exists("/.flatpak-info") should do.

Matoking commented 3 years ago

Hm, maybe detect flatpak sandbox at run time instead of adding a downstream patch? A check like os.path.exists("/.flatpak-info") should do.

That seems like a better idea. And in hindsight, removing the --no-bwrap flag could also cause some issues when it would be better to print a warning stating that the flag is a no-op when used inside a Flatpak sandbox.