flathub / com.valvesoftware.Steam

https://flathub.org/apps/details/com.valvesoftware.Steam
336 stars 70 forks source link

Block `libtcmalloc_minimal.so.4` to avoid game crashes #1171

Closed doraskayo closed 8 months ago

doraskayo commented 9 months ago

Source games started to crash in their vendored versions of libtcmalloc_minimal.so.4 after the Freedesktop SDK runtime was updated to 23.08.

Falling back to the version built in the app manifest seems to avoid the crash.

Closes: https://github.com/flathub/com.valvesoftware.Steam/issues/1158

doraskayo commented 9 months ago

bot, build

flathubbot commented 9 months ago

Queued test build for com.valvesoftware.Steam.

flathubbot commented 9 months ago

Started test build 69747

flathubbot commented 9 months ago

Build 69747 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52398/com.valvesoftware.Steam.flatpakref
flathubbot commented 9 months ago

Started test build 69952

flathubbot commented 9 months ago

Build 69952 failed

doraskayo commented 9 months ago

bot, build

flathubbot commented 9 months ago

Queued test build for com.valvesoftware.Steam.

flathubbot commented 9 months ago

Started test build 69957

flathubbot commented 9 months ago

Build 69957 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52611/com.valvesoftware.Steam.flatpakref
doogie544 commented 9 months ago

as mentioned here it works for all but No More Room in Hell b/c I made a mistake in copying the game path. If you remove the problem libmalloc lib from the game it works so correcting the mistake made because of my mistake should fix it for all games

The folder name for the game should be nmrih not mrih

https://github.com/flathub/com.valvesoftware.Steam/issues/1158#issuecomment-1741784009

flathubbot commented 9 months ago

Started test build 70096

doraskayo commented 9 months ago

The folder name for the game should be nmrih not mrih

Fixed. Thanks for double-checking!

flathubbot commented 9 months ago

Build 70096 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52748/com.valvesoftware.Steam.flatpakref
doogie544 commented 9 months ago

I can confirm that this now works for No More Room in Hell now

doogie544 commented 8 months ago

@doraskayo any word on this PR? It is likely to be merged or is there some concern about this method of working around the issue?

Also idk how I left it off the list when testing but counter strike source also is affected by this issue.

The libmalloc lib is in /Counter-Strike Source/bin The exe for the game is also hl2_linux

flathubbot commented 8 months ago

Started test build 73916

flathubbot commented 8 months ago

Build 73916 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/56564/com.valvesoftware.Steam.flatpakref
doraskayo commented 8 months ago

@doraskayo any word on this PR? It is likely to be merged or is there some concern about this method of working around the issue?

Also idk how I left it off the list when testing but counter strike source also is affected by this issue.

The libmalloc lib is in /Counter-Strike Source/bin The exe for the game is also hl2_linux

Thanks, but I won't be able to update this PR further. Feel free to open a separate PR with this addition.

flathubbot commented 8 months ago

Started test build 73925

flathubbot commented 8 months ago

Build 73925 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/56573/com.valvesoftware.Steam.flatpakref