search

flathub / com.valvesoftware.Steam

https://flathub.org/apps/details/com.valvesoftware.Steam
336 stars 70 forks source link

Add ownership to com.steampowered.PressureVessel.LaunchAlongsideSteam.* #1200

Closed TheOriginalBurgerKing closed 7 months ago

TheOriginalBurgerKing commented 7 months ago

Add ownership to com.steampowered.PressureVessel.LaunchAlongsideSteam.* to resolve errors found in issues.

Unable to acquire bus name "com.steampowered.PressureVessel.LaunchAlongsideSteam" https://github.com/flathub/com.valvesoftware.Steam/issues/1168#issuecomment-1741710694

I have not tested building.

flathubbot commented 7 months ago

Started test build 83990

flathubbot commented 7 months ago

Build 83990 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66630/com.valvesoftware.Steam.flatpakref
nanonyme commented 7 months ago

I would like to have comment from @smcv whether this is actually an expected change.

nanonyme commented 7 months ago

https://github.com/flathub/com.valvesoftware.Steam/issues/1166#issuecomment-1742799353

Looks like @smcv recommendation was adding --own-name=com.steampowered.PressureVessel.*

nanonyme commented 7 months ago

Let's add appropriately large hole. Not too big (com.streampowered is quite large) and not too small (com.steampowered.PressureVessel.LaunchAlongsideSteam won't allow future things pressure vessel might need).

smcv commented 7 months ago

--own-name=com.steampowered.PressureVessel.* is definitely proportionate, please add that as a minimum. [edit: that's #1209]

I think --own-name=com.steampowered.* [edit: #1208] would actually make sense. It is a domain name owned by Valve and used for the Steam app-store, and it will become necessary if users of the Flatpak app want to make use of a developer/debug interface provided by the container runtime, which makes per-game containers listen for commands from the host system on names like com.steampowered.App123 (vaguely similar in principle to flatpak enter, but using IPC similar to flatpak-spawn --host rather than messing with namespaces).

smcv commented 7 months ago

Based on my knowledge of Steam and the Steam Runtime, I would personally recommend #1208.

If not #1208, then please consider #1209.

I think either of those would be better than the current state of this PR.

@TheOriginalBurgerKing, thank you for reminding me to propose those!

barthalion commented 7 months ago

Closing in favour of https://github.com/flathub/com.valvesoftware.Steam/pull/1208.

smcv commented 7 months ago

Closing in favour of #1208.

(It isn't closed yet, please could a maintainer or the author do that?)

barthalion commented 7 months ago

Oops, must have pressed wrong button.