search

flathub / com.valvesoftware.Steam

https://flathub.org/apps/details/com.valvesoftware.Steam
335 stars 70 forks source link

Steam client now requires at least Flatpak 1.12 #1239

Closed smcv closed 2 months ago

smcv commented 5 months ago

The Steam client beta uses pressure-vessel (Steam Linux Runtime) to launch steamwebhelper in a Steam Runtime 3.0 (sniper) environment. This is the same way that Proton 5.13+ games work, and also the same way that Steam Linux Runtime native Linux games work (CS2, Dota 2, Endless Sky, Retroarch etc.). In Flatpak-world, this requires creating a subsandbox from a specified /usr, which is a Flatpak 1.12+ feature.

I think it might be time to bump the required Flatpak version for this app to 1.12 - if not now, then certainly when this Steam client beta ships as stable.

smcv commented 5 months ago

This will also require support for unprivileged creation of user namespaces (a non-setuid bwrap executable) as per unprivileged bubblewrap. It will no longer be possible to run a Flatpak'd Steam with setuid bubblewrap after this change.

This will simplify https://github.com/flathub/com.valvesoftware.Steam/wiki#steam-play-games-do-not-start-for-me considerably: the situation will become "you must have these OS features, or the app just won't work".

barthalion commented 5 months ago

Hey @smcv, mind poking me when the beta client is shipped to stable? I will handle it.

smcv commented 4 months ago

The beta client has been shipped as stable.

I see the required version was already bumped to 1.11.1 in #905, so in fact the major part of this has already been resolved.

I very much hope that nobody is still using 1.11.x development prereleases that ceased to be security-supported with the release of 1.12.0 in 2021, and everyone should have moved to 1.12.x or 1.14.x by now (except possibly users of oldstable/oldLTS distributions like Debian 11 or older RHEL, who might still be on 1.8.x or 1.10.x which already cannot install/run Steam since #905, but those users should ideally be using backports of something newer, like the official backport of 1.14.4 from Debian 12 to 11).

I think it might be worthwhile to make this official by bumping the required version to something in the 1.12.x series.

RokeJulianLockhart commented 2 months ago

https://github.com/flathub/com.valvesoftware.Steam/issues/1239#issuecomment-1978559038

@barthalion, per https://github.com/flathub/com.valvesoftware.Steam/pull/1267#event-12013493731, has this been remediated?