flathub / com.valvesoftware.Steam

https://flathub.org/apps/details/com.valvesoftware.Steam
339 stars 69 forks source link

Can't install self-built Flatpak due to an invalid icon #638

Open PureTryOut opened 3 years ago

PureTryOut commented 3 years ago

After removing the steamcmd module to workaround #637 for now, the built Flatpak fails to install (or export to a repo):

error: /home/bart/Documents/Git/com.valvesoftware.steam/build-dir/export/share/icons/hicolor/16x16/apps/com.valvesoftware.Steam.png is not a valid icon: bwrap: Can't find source path /etc/ld.so.cache: No such file or directory

Export failed: Child process exited with code 1
nanonyme commented 3 years ago

I don't know what's going on here. Are you using the build.sh in the repo? Which version of flatpak and flatpak-builder do you have?

PureTryOut commented 3 years ago

It's been a while since I've tried this, but afaik yes I tried both with build.sh and without it. Currently my Flatpak and builder version are 1.8.3 and 1.0.11 respectively, but I'm unsure what it was at the time of reporting.

nanonyme commented 3 years ago

Okay. Can't reproduce either of the issues. Which distro and version is this with?

PureTryOut commented 3 years ago

Alpine Linux and whatever the version of the Flatpak was in use back then. If you give me a bit I'll try again.

nanonyme commented 3 years ago

I would be on this being another issue that musl is incompatible with flatpak. Most esoteric bugs are reported from Alpine Linux.

PureTryOut commented 3 years ago

Flatpak works fine with Musl, the whole point of the thing is that such differences are abstracted away. The Steam Flatpak itself (and any other really) works fine for me, it's just building that it has issues with for some reason.

And "not a valid icon" doesn't sound like a Musl issue tbh.

nanonyme commented 3 years ago

There's tons of bug reports about eg symlink handling being broken in esoteric ways. Things were supposed to improve but at one point musl promise was it is a POSIX-compliant libc only in the precence of fully working /proc (which is not the case with flatpak, there's PID namespaces through bubblewrap) and flatpak only promises to support POSIX-compliant libc's.

gasinvein commented 3 years ago

I guess "not a valid icon" is not the real issue here, this one is: bwrap: Can't find source path /etc/ld.so.cache: No such file or directory I mean, it doesn't seem to have anything to do with icons, really. Probably it worth reporting to flatpak?

nanonyme commented 3 years ago

Sure though musl bugs tend to remain open.