Make ssh agent socket usable in the sandbox

flathub / com.visualstudio.code.oss

https://flathub.org/apps/details/com.visualstudio.code.oss

GNU Affero General Public License v3.0

47 stars 12 forks source link

Make ssh agent socket usable in the sandbox #10

Closed mzabaluev closed 6 years ago

mzabaluev commented 6 years ago

The Visual Studio Code application can use git provided by the runtime, but it does not work with the ssh authentication agent provided by the desktop user session. It would be nice if $SSH_AUTH_SOCK from the host was made available in the sandbox and the environment variable imported. It seems easy to do with bwrap accordingly to flatpak/flatpak#1438.

amtlib-dot-dll commented 6 years ago

It seems easy to do with bwrap accordingly to flatpak/flatpak#1438.

So I am afraid I am not able to help this, as an application maintainer but not a platform maintainer, because I am not able to alter bwrap by changing the application

gasinvein commented 5 years ago

@amtlib-dot-dll A --socket=ssh-auth permission is implemented now, you can just add it to finish-args.

amtlib-dot-dll commented 5 years ago

Added in 2225a59fec8d3220bd6f53bf4c39fb9e38d218f6, thanks!