search

flathub / com.visualstudio.code.oss

https://flathub.org/apps/details/com.visualstudio.code.oss
GNU Affero General Public License v3.0
47 stars 12 forks source link

Enabling arm #18

Closed nedrichards closed 6 years ago

nedrichards commented 6 years ago

Fixes #17

nedrichards commented 6 years ago

bot, build

amtlib-dot-dll commented 6 years ago

Are we doing the same thing? :joy: :joy:

amtlib-dot-dll commented 6 years ago

bot, build

amtlib-dot-dll commented 6 years ago

It works!

BTW, as this recipe is automatically generated from a Python script, may you add a writable deploy key to this repository? I am not able to do this as I am not the owner, and I am now copying and pasting from the output of Travis CI. Thank you very much!

nedrichards commented 6 years ago

I confirm that it works locally as well. I want to switch this to the new baseapp as well.

nedrichards commented 6 years ago

As for a writable deploy key, that's not something that we want to do right now as we still want a human in the loop until we have per app "channels" like a beta channel for testing.

amtlib-dot-dll commented 6 years ago

You can have a try. The new base app makes the libxkbfile in this recipe obsolete and that entry can be removed. However we should stay in the 1.6 branch because #12 complains that pinentry is missing in the 18.08 runtime.

I can just give my personal access token to Travis CI for automatic commits but I just want a more secure solution for me 😃

amtlib-dot-dll commented 6 years ago

A deploy key prevents my other repositories from being accessed while updating this repository, compared with that personal access token