search

flathub / com.visualstudio.code.oss

https://flathub.org/apps/details/com.visualstudio.code.oss
GNU Affero General Public License v3.0
47 stars 12 forks source link

Visual Studio Code OSS file dialog bug #38

Open tapir opened 5 years ago

tapir commented 5 years ago

VSCode OSS's file dialog doesn't adhere to global Gnome theme, nor does it show the bookmarks

amtlib-dot-dll commented 5 years ago

I think that it's time to upgrade to the latest runtime

tapir commented 5 years ago

You mean that it's fixed now or I was using an out dated runtime?

amtlib-dot-dll commented 5 years ago

I've upgraded the runtime to the latest one, please try it and tell us whether your problem still exists.

tapir commented 5 years ago

The problem still persists. File dialog is still not adhering to the dark theme like all other apps and it doesn't show nautilus bookmarks.

amtlib-dot-dll commented 5 years ago

Will the proprietary version https://github.com/flathub/com.visualstudio.code have the same issue?

tapir commented 5 years ago

The proprietary version is the same

amtlib-dot-dll commented 5 years ago

That's weird. I wish there would be a GNOME developer answering where GNOME file dialog stores the "Recent" data

tapir commented 5 years ago

It's not recent data though. It's bookmarks. People can explicitly set bookmarks on nautilus and it will show in the file dialog as well.

Also the the theme. So I'm guessing it doesn't use user's nautilus settings at all.

amtlib-dot-dll commented 5 years ago

Perhaps. Would you give us some examples of Flatpak applications which can read nautilus settings? BTW, I am curious about whether Visual Studio Code outside Flatpak read those data

tapir commented 5 years ago

All the gnome apps can use them. From flathub I'm using gnome-books, gnome-notes, gnome-documents, etc... And yes the vscode from arch linux repo does use the global settings as well.

amtlib-dot-dll commented 5 years ago

Try this?

flatpak run --filesystem=xdg-run/dconf --filesystem=~/.config/dconf:ro --talk-name=ca.desrt.dconf --env=DCONF_USER_CONFIG_DIR=.config/dconf com.visualstudio.code.oss

Well it seems not working :thinking:

tapir commented 5 years ago

unfortunately no

tapir commented 5 years ago

I don't know if this helps but from the flatpak website: "Portals"

Examples of capabilities that can be accessed through portals include opening files through a file chooser dialog, or printing. Interface toolkits can implement transparent support for portals, so access to resources outside of the sandbox will work securely and out of the box.
amtlib-dot-dll commented 5 years ago

Visual Studio Code does not use Portals, and many other non-GNOME applications have the same issue. Stay tuned