The new build - Githubissues

gasinvein commented 4 years ago

Differences from previous flatpak recepies:

flatpak-node-generator.py with several changes (patches pending) is used to generate sources for yarn packages and things they download
Added wrapper script, derived from VS Code flatpak (the proprietary one)
- Node.js, Python and Cargo packages are isolated from the host
- SDK extensions are enabled automatically if set in FLATPAK_ENABLE_SDK_EXT env var
Tools extensions from VS Code flatpak are reused
VS Code is patched to put IPC sockets in a directory shared between instances, so opening files in existing window (flathub/com.visualstudio.code#75) works now
- Live Share should work as well given its external dependencies (krb5, openssl 1.0 and xprop) are satisfied
Builtin marketplace extensions are disabled for now; until bundled, they can be installed manually from marketplace

Closes #46

Todo:

[x] Automate appstream releases generation
[ ] Pre-download specified versions of node-headers
[ ] Bundle marketplace extensions (or not)

NB: This build is affected by flathub/com.visualstudio.code#159 (may freeze on launch or workspace switch), cause unknown yet, help wanted.

flathubbot commented 4 years ago

Started test build 20991

flathubbot commented 4 years ago

Build 20991 failed

flathubbot commented 4 years ago

Started test build 20996

flathubbot commented 4 years ago

Started test build 20997

flathubbot commented 4 years ago

Build 20996 was cancelled

flathubbot commented 4 years ago

Build 20997 was cancelled

flathubbot commented 4 years ago

Started test build 20999

flathubbot commented 4 years ago

Build 20999 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/20148/com.visualstudio.code.oss.flatpakref

flathubbot commented 4 years ago

Started test build 21465

flathubbot commented 4 years ago

Build 21465 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/20601/com.visualstudio.code.oss.flatpakref

gasinvein commented 4 years ago

Did anyone test this? @TingPing maybe? I'd like to know if there are any problems besides flathub/com.visualstudio.code#159 before merging it.

tim77 commented 4 years ago

LGTM. Please, update.

flathubbot commented 4 years ago

Started test build 21646

flathubbot commented 4 years ago

Build 21646 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/20783/com.visualstudio.code.oss.flatpakref

Unrud commented 4 years ago

The settings telemetry.enableTelemetry and telemetry.enableCrashReporter are not disabled by default. Maybe also set update.mode to none because automatic updates are pointless for this package.

gasinvein commented 4 years ago

@Unrud I guess updates don't work in unofficial builds regardless of settings.

Unrud commented 4 years ago

I guess updates don't work in unofficial builds regardless of settings.

You are right, the Check for Updates... button is missing even if it's enabled. Then you can ignore my comment.

eternal-sorrow commented 4 years ago

Then you can ignore my comment.

There's still telemetry though.

gasinvein commented 4 years ago

@eternal-sorrow Does it work in unofficial builds either?

eternal-sorrow commented 4 years ago

Why wouldn't it work?

gasinvein commented 4 years ago

It's probably not useful for MS since the build may be altered in arbitrary way. Anyway, I don't see where/how current build changes telemetry settings.

mzabaluev commented 4 years ago

While you are at it, can we deconflict the apps with com.visualstudio.code by not making them share the ID prefix? I've had some strangeness occur in GNOME Software, it looked like the OSS app masked out updates available for com.visualstudio.code, or something to that effect.

mzabaluev commented 4 years ago

While you are at it, can we deconflict the apps with com.visualstudio.code by not making them share the ID prefix?

io.github.microsoft.VSCode would seem acceptable accordingly to the conventions and clearly indicate this app as derived from open source. Or perhaps org.flathub.app.microsoft.VSCode because control issues.

eternal-sorrow commented 4 years ago

It's probably not useful for MS since the build may be altered in arbitrary way.

It's more about "peace of mind" that not a single byte of data is sent to MS servers. So, I, personally, would like to have these options disabled by default.

mzabaluev commented 4 years ago

It's more about "peace of mind" that not a single byte of data is sent to MS servers.

Since they are the main contributor to the OSS codebase and they are fine with telemetry being used by derived projects, I don't think it is an issue for Microsoft. As for telemetry being enabled by default, I don't have a strong opinion. Maybe disable sending any information that might be personally identifying?

eternal-sorrow commented 4 years ago

I don't think it is an issue for Microsoft

I never said that. It's an issue for me. I'd even prefer the code related to telemetry removed from the codebase completely.

gasinvein commented 4 years ago

@mzabaluev

While you are at it, can we deconflict the apps with com.visualstudio.code by not making them share the ID prefix? I've had some strangeness occur in GNOME Software, it looked like the OSS app masked out updates available for com.visualstudio.code, or something to that effect.

Tell it to @TingPing. I've already asked to change ID.

gasinvein commented 4 years ago

Closing in favor of flathub/flathub#1596

flathub / com.visualstudio.code.oss

The new build #56