flathub / com.visualstudio.code

https://flathub.org/apps/details/com.visualstudio.code
136 stars 68 forks source link

Invalid instructions in README #466

Closed tryonelove closed 4 months ago

tryonelove commented 8 months ago

Hello,

I wonder if the following config is correct:

    "terminal.integrated.defaultProfile.linux": "bash",
    "bash": {
      "path": "/app/bin/host-spawn",
      "args": ["bash"],
      "icon": "terminal-bash",
      "overrideName": true
    },

VS Code doesn't support the bash option; I believe it should be similar to the flatpak-spawn --host configuration.

{
  "terminal.integrated.defaultProfile.linux": "bash",
  "terminal.integrated.profiles.linux": {
     "bash": {
      "path": "/app/bin/host-spawn",
      "args": ["bash"],
      "icon": "terminal-bash",
      "overrideName": true
    },
  }
}
flibitijibibo commented 7 months ago

Ended up getting a report from FNA's end about this, #478 should fix this.