flathub / com.vscodium.codium

https://flathub.org/apps/details/com.vscodium.codium
94 stars 19 forks source link

Adding `host-spawn` for nicer integrated terminal experience #255

Closed iro-miya closed 6 months ago

iro-miya commented 8 months ago

In order to use the integrated terminal on the host system, users have to use flatpak-spawn, as explained in the README. Currently, flatpak-spawn has quite a few issues, especially that it doesn't allocate TTY properly which breaks some shells. A better implementation called host-spawn was made to fix these issues and it's included by default in the VS Code Flatpak.

Could it also be included in this one? That would be so useful!

ghost commented 7 months ago

doesn't allocate TTY properly which breaks some shells.

I use flatpak-spawn to enter a toolbox with fish as a default shell It sometimes glitches out but usually everything works alright

imo it is a minor annoyance rather than something severe

noonsleeper commented 7 months ago

@larina3315 there is no problem because both implementation can coexist at the same time.

vtrenton commented 6 months ago

Didn't realize there was already an issue for this. I'll close my issue and attach my PR to this issue then.