flathub / com.vscodium.codium

https://flathub.org/apps/details/com.vscodium.codium
95 stars 20 forks source link

Allow access to .gitconfig #281

Closed ghost closed 8 months ago

ghost commented 8 months ago

By default, VSCodium flatpak is allowed full access to an user's home directory. The FAQ guides users on how to disable the home directory access and enable access to specific directory.

But doing so breaks committing/pushing to git repos as VSCodium loses access to ~/.gitconfig and errors out. This is why I have created this PR, It introduces a one-line change that explicitly grants access to ~/.gitconfig , so in the case the user decides to disable home directory access and grant access to a specific directory, git still continues to function.

Note that --persist can also be used instead of --filesystem to isolate the ~/.gitconfig file from user's own home.

flathubbot commented 8 months ago

Started test build 92570

flathubbot commented 8 months ago

Build 92570 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/75253/com.vscodium.codium.flatpakref
flathubbot commented 8 months ago

Started test build 93397

flathubbot commented 8 months ago

Build 93397 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/76140/com.vscodium.codium.flatpakref
noonsleeper commented 8 months ago

Sorry, but this is a custom config for a particular use case that doesn't involve any fix or enhance for this package. Maybe will be better that you add a comment about this on the FAQ?

ghost commented 8 months ago

Sorry, but this is a custom config for a particular use case that doesn't involve any fix or enhance for this package. Maybe will be better that you add a comment about this on the FAQ?

Understandable, I will file a PR against the FAQ instead