search

flathub / com.vscodium.codium

https://flathub.org/apps/details/com.vscodium.codium
94 stars 19 forks source link

Screenshot size #290

Open bertob opened 5 months ago

bertob commented 5 months ago

Hi, I noticed that there's a request for re-review, but it looks to me like the window size on the screenshots is still significantly larger than 1000x700. Am I missing something?

noonsleeper commented 5 months ago

Hi @bertob, Thanks for the comment, I'll fix that!

bertob commented 5 months ago

I think there was a misunderstanding. The guidelines are not about the pixel size per se (e.g. you could also provide 2x HiDPI screenshot), but about the actual size of the window when the screenshot is taken. For appdata you need screenshots that are legible scaled-down on app stores, and that requires the windows not being too large. Scaling down the assets doesn't help with this, instead what this needs is new screenshots taken at a smaller size, at their original resolution.

noonsleeper commented 5 months ago

@bertob, you think this will be good?

test_screenshot

or this

test2_screenshot

bertob commented 5 months ago

The former is too large, the latter is on the small side but would work. I'd maybe use a more visually interesting code sample though, e.g. code with a lot of nesting and lots of different highlighting colors.

By the way, is this is the default setup? With the visible menubar, light gtk theme, but dark app? This goes beyond the Flathub guidelines, but would be great to avoid mixed dark/light.

noonsleeper commented 5 months ago

is this is the default setup? With the visible menubar, light gtk theme, but dark app?

Sadly to say, yes it is. (these screenshots are for a brand-new fedora 39 vm with vanilla vscodium also with the default title bar native) Will be good if I change the default (dark theme) for the white theme?

The another type of title bar, custom (I don't know how picks this name) is more like the actual Gnome style, but also the default is dark theme.

bertob commented 5 months ago

Will be good if I change the default (dark theme) for the white theme?

Well ideally that should be changed upstream so that people get that experience when they actually install the app :)

No idea how close you are to upstream/how involved that would be, but might be worth proposing just following the system dark/light setting there, and switching the gtk stylesheet accordingly too?