search

flathub / com.vscodium.codium

https://flathub.org/apps/details/com.vscodium.codium
94 stars 19 forks source link

Workaround the sync issue #294

Closed ghost closed 4 months ago

ghost commented 5 months ago

This PR adds --password-store="basic" launch argument to the -Deditor_args= section of the flatpak manifest file to workaround sync being broken (Github credentials getting reset everytime you close VSC)

flathubbot commented 5 months ago

Started test build 97813

flathubbot commented 5 months ago

Build 97813 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/80587/com.vscodium.codium.flatpakref
noonsleeper commented 5 months ago

Is this change modify the behavior to other DE like KDE? https://github.com/flathub/com.vscodium.codium/issues/267

ghost commented 5 months ago

Is this change modify the behavior to other DE like KDE? #267

Currently, VSC uses the Kwallet service on KDE for storing credentials. With this change it will stop using Kwallet, but sync should still work regardless. The change makes VSC store credentials in cleartext for all DEs. https://chromium.googlesource.com/chromium/src/+/HEAD/docs/linux/password_storage.md

Do note that this is intended to be used as a workaround, when sync of VSC flatpak(s) start working with GNOME (and maybe other affected DEs) using libsecret again it can be removed.

ghost commented 4 months ago

Any updates on whether this will be merged or not ? Or if the issue is already resolved in newer VSCodium builds/versions ?

daiyam commented 4 months ago

Which sync are you talking?

ghost commented 4 months ago

Which sync are you talking?

https://github.com/flathub/com.vscodium.codium/issues/282 this i don't think "sync" would be the ideal word, but it broke syncing with MS accounts in VSCode too and was initially referred to as such.

Eitherway, in the case of VSCodium, login credentials are stored by VSCodium when an user signs into Github from VSCodium to manage/clone their Github repos.

But, on subsequent launches after VSCodium gets closed, the user needs to sign in again, normal expected behaviour is you stay signed in to your Github account.

Login credential persistence/sync issue was persistent on both GNOME and KDE VSCodium uses libsecret backend on GNOME (and probably other GTK desktops) and the Kwallet backend on KDE. I submitted a PR prior that added some dbus buses related to Kwaller to the flatpak manifest and the issue was fixed on KDE/Kwallet. But, on GNOME/libsecret it was broken for months. This PR was meant to be a temporary workaround to the Login credential persistence/sync issue, so VSCodium doesn't use libsecret/kwallet and sync works again.

noonsleeper commented 4 months ago

@larina3315 I'll add an EXTRA_ARGS env to the ide-flatpak-wrapper for this kind of thing, add these broke the KDE behaviour

ghost commented 4 months ago

@larina3315 I'll add an EXTRA_ARGS env to the ide-flatpak-wrapper for this kind of thing, add these broke the KDE behaviour

i see, I'll close the PR then