search

flathub / com.vscodium.codium

https://flathub.org/apps/details/com.vscodium.codium
94 stars 19 forks source link

Enable wayland #295

Closed ghost closed 4 months ago

ghost commented 5 months ago

This PR adds necessary launch args to the -Deditor_args= section of the flatpak manifest to enable native wayland by default. Note that for the launch arguments to work, --socket=X11 needs to be disabled and --socket=wayland and --socket=fallback-x11 needs to be enabled

During testing, I noticed that,

It seems like some quirk with --ozone-platform-hint=auto. So far,

The maintainers might want to consider this while reviewing this PR.

flathubbot commented 5 months ago

Started test build 97814

flathubbot commented 5 months ago

Build 97814 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/80588/com.vscodium.codium.flatpakref
flathubbot commented 5 months ago

Started test build 97816

flathubbot commented 5 months ago

Build 97816 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/80590/com.vscodium.codium.flatpakref
noonsleeper commented 5 months ago

see https://github.com/flathub/com.vscodium.codium/issues/296 this will be better to tackle with some modifications to https://github.com/flathub/ide-flatpak-wrapper.git with some env-vars checking, before change this to wayland as default

ghost commented 5 months ago

see #296 this will be better to tackle with some modifications to https://github.com/flathub/ide-flatpak-wrapper.git with some env-vars checking, before change this to wayland as default

In that case I am interested to help on that. Implementing a wayland switch in the wrapper itself would make it more universal, instead of being used on a project-by-project basis.