flathub / com.vscodium.codium

https://flathub.org/apps/details/com.vscodium.codium
94 stars 19 forks source link

Primary brand colors #311

Closed noonsleeper closed 2 months ago

noonsleeper commented 4 months ago

@daiyam I look on flathub's website and see this marked as a problem

Pasted image 1

those refer to the flatpak docs:

VSCodium/Insiders has some brand colors? If not, can you help me on this?

noonsleeper commented 4 months ago

BTW sorry to bother on this

daiyam commented 4 months ago

Seems like they want the icon of the app (the circle one with white background)

noonsleeper commented 4 months ago

Then I look for what hex color for the background on that icon for the ligth primary, but what about the dark color?

daiyam commented 4 months ago

The correct icon is https://github.com/VSCodium/vscodium/blob/master/src/stable/resources/linux/code.png

Oh! https://raw.githubusercontent.com/VSCodium/vscodium/5e26c4a9c475ebf59052c2da916b80d471af739f/icons/stable/codium_cnl.svg is building block to build the macos and windows icons (https://github.com/VSCodium/vscodium/blob/ed0de172c4a459a3c3d3eaccb1fc34b22afdd454/icons/build_icons.sh#L41C50-L41C64)

It's already in the .deb at usr/share/codium-insiders/resources/app/resources/linux/code.png

daiyam commented 4 months ago

Damn! I've looked at something else... Anyway, the icons will need to be fixed.

noonsleeper commented 4 months ago

The correct icon is https://github.com/VSCodium/vscodium/blob/master/src/stable/resources/linux/code.png

I'll change the icon, but is there an SVG version?

daiyam commented 4 months ago

I'll change the icon, but is there an SVG version?

No. But I could make one. Is it needed?

For the brand colors, I will get back to you later.

noonsleeper commented 4 months ago

Not needed right now, don't worry, I'll use the icon that you already give me, that has a resolution of 1024x1024 then will be good enough.

And later I'll try to add an SVG version on vscodium repo, I don't want to give you more work on this that the needed for the colors :wink:

daiyam commented 4 months ago

And later I'll try to add an SVG version on vscodium repo

Don't worry, the elements of the icons are already available at:

noonsleeper commented 4 months ago

And later I'll try to add an SVG version on vscodium repo Don't worry, the elements of the icons are already available at:

Very useful indeed, It took me a while, but I built a clean replica of the png version with those assets https://github.com/VSCodium/vscodium/pull/1818 =).

daiyam commented 4 months ago

Ok, I've created the PR (in the right repos...) to add the "brand" colors.

noonsleeper commented 4 months ago

Thanks @daiyam!