search

flathub / com.vscodium.codium

https://flathub.org/apps/details/com.vscodium.codium
94 stars 19 forks source link

[Discussion] General question about the wrapper repo #336

Closed daiyam closed 4 weeks ago

daiyam commented 2 months ago

Hi @noonsleeper,

I was wondering if it would be good to move your https://github.com/noonsleeper/ide-flatpak-wrapper repo under VSCodium org and to use the master branch instead of wayland-support. Of course, you will maintain full access to the repo.

What do you think?

noonsleeper commented 2 months ago

Hey @daiyam,

TL;DR: to me is a good idea and if you like that way I can move the repo to codium org without hesitation =).

Now the large explanation xD

Originally it was created to merge PR on upstream branch zypak, but sometimes I can't wait then I use the fork until changes are merged, like in this particular case =).

Also, I was thinking to ask admins if I can be added as a maintainer on upstream.

daiyam commented 2 months ago

Now, I understand. First, I will push your PR. If nothing happened, then you can move the fork.

noonsleeper commented 1 month ago

Hi @daiyam, I made some changes on that PR 2 weeks ago, but I don't see any move

daiyam commented 1 month ago

Yep. Maybe, try to reformat the ifs to match the existing format (if []; then\n), push it and then ask for an update.