search

flathub / com.yubico.yubioath

https://flathub.org/apps/details/com.yubico.yubioath
9 stars 10 forks source link

System theme #21

Closed ai closed 2 years ago

ai commented 2 years ago

Flathub version of Yubico Authenticator doesn’t see system dark/light theme changes.

  1. Settings → Appearance: System default
  2. Enable dark mode (set Adwaita-dark theme for GNOME)
  3. Run Yubico Authenticator
  4. We have light theme, not dark (both app and window decoration are light).

Why it is important: schedule-based theme changes are popular.

@Lunarequest any idea how to fix it? Maybe we need to add permission to check system theme?

Lunarequest commented 2 years ago

Yubioath is a qt based app last I checked gnome doesn't theme qt apps

Lunarequest commented 2 years ago

@ai try installing the following flatpaks org.kde.KStyle.Adwaita and org.kde.PlatformTheme.QGnomePlatform. It should make everything automatically theme. I can confirm that on KDE plasma yubioath picks up breeze dark on its own

ai commented 2 years ago

I already have org.kde.KStyle.Adwaita and org.kde.PlatformTheme.QGnomePlatform (both 5.15)

$ flatpak install org.kde.PlatformTheme.QGnomePlatform org.kde.KStyle.Adwaita
Looking for matches?
Remotes found with refs similar to ?org.kde.PlatformTheme.QGnomePlatform?:

   1) ?flathub? (system)
   2) ?flathub? (user)

Which do you want to use (0 to abort)? [0-2]: 1
Similar refs found for ?org.kde.PlatformTheme.QGnomePlatform? in remote ?flathub? (system):

   1) runtime/org.kde.PlatformTheme.QGnomePlatform/x86_64/5.9
   2) runtime/org.kde.PlatformTheme.QGnomePlatform/x86_64/5.10
   3) runtime/org.kde.PlatformTheme.QGnomePlatform/x86_64/5.11
   4) runtime/org.kde.PlatformTheme.QGnomePlatform/x86_64/5.12
   5) runtime/org.kde.PlatformTheme.QGnomePlatform/x86_64/5.13
   6) runtime/org.kde.PlatformTheme.QGnomePlatform/x86_64/5.14
   7) runtime/org.kde.PlatformTheme.QGnomePlatform/x86_64/5.15

Which do you want to use (0 to abort)? [0-7]: 7
Skipping: org.kde.PlatformTheme.QGnomePlatform/x86_64/5.15 is already installed
Similar refs found for ?org.kde.KStyle.Adwaita? in remote ?flathub? (system):

   1) runtime/org.kde.KStyle.Adwaita/x86_64/5.9
   2) runtime/org.kde.KStyle.Adwaita/x86_64/5.10
   3) runtime/org.kde.KStyle.Adwaita/x86_64/5.11
   4) runtime/org.kde.KStyle.Adwaita/x86_64/5.12
   5) runtime/org.kde.KStyle.Adwaita/x86_64/5.13
   6) runtime/org.kde.KStyle.Adwaita/x86_64/5.14
   7) runtime/org.kde.KStyle.Adwaita/x86_64/5.15

Which do you want to use (0 to abort)? [0-7]: 7
Skipping: org.kde.KStyle.Adwaita/x86_64/5.15 is already installed

But I have light version of app in dark theme of GNOME

20211012094914

Lunarequest commented 2 years ago

It definitely a gnome issue since it works just fine on kde plasma. Could you try building a custom build with runtime version 5.15?

ai commented 2 years ago

Could you try building a custom build with runtime version 5.15?

Sure. How I can do it?

Lunarequest commented 2 years ago

Just change the runtime version and rebuild it how you normally do

ai commented 2 years ago

What versions I should try? (theme auto-switching doesn’t work before too)

How can I re-build?

Lunarequest commented 2 years ago

5.15

ai commented 2 years ago

On previous version of 5.15 it was the same issue.

Is it OK to use PRs to re-build packages?

Lunarequest commented 2 years ago

I'd prefer if you use flatpak-builder on your system

ai commented 2 years ago

It fixed. Thanks. PR https://github.com/flathub/com.yubico.yubioath/pull/22

Lunarequest commented 2 years ago

The required packages are now up to date I am closing this issue