Change in build 117032 rejected

flathubbot commented 1 month ago

A change in build 117032 has been reviewed by the Flathub team, and rejected for the following reason:

This should be Wayland compatible since you are building Qt 6.7. In that case please use --socket=wayland and --socket=fallback-x11. If not please say what issues there are with running wayland by default.

Changes

Field Old value New value

sockets ['wayland', 'x11'] ['x11']

Field	Old value	New value
sockets	['wayland', 'x11']	['x11']

hfiguiere commented 1 month ago

You should just use the KDE 6.7 runtime and not build Qt in the manifest.

kebekus commented 1 month ago

@hfiguiere Thank you for your comment. I was surprised that the KDE runtime is available in Qt versions as recent as 6.7. I gave the KDE 6.7 runtime/Sdk a try but ran into problems that I was unable to solve. Could you please give me a hint?

The command flatpak-builder fails with the following error message, which I need help to make sense of.

[…]

-- Installing: /app/qml/QtQuick/libqtquick2plugin.so
CMake Error at /usr/lib/x86_64-linux-gnu/cmake/Qt6Core/Qt6CoreDeploySupport.cmake:139 (file):
  file RPATH_SET could not write new RPATH:

    $ORIGIN/../../lib

  to the file:

    /app/qml/QtQuick/libqtquick2plugin.so

  No valid ELF RPATH or RUNPATH entry exists in the file;
Call Stack (most recent call first):
  /usr/lib/x86_64-linux-gnu/cmake/Qt6Qml/Qt6QmlDeploySupport.cmake:304 (_qt_internal_set_rpath)
  .qt/deploy_qml_imports/addhoursandminutes.cmake:10 (_qt_internal_deploy_qml_imports_for_target)
  /usr/lib/x86_64-linux-gnu/cmake/Qt6Qml/Qt6QmlDeploySupport.cmake:59 (include)
  .qt/deploy_qml_app_addhoursandminutes_d688d3e55a.cmake:5 (qt6_deploy_qml_imports)
  src/cmake_install.cmake:66 (include)
  cmake_install.cmake:57 (include)

FAILED: CMakeFiles/install.util 
cd /run/build/addHoursAndMinutes && /usr/bin/cmake -P cmake_install.cmake
ninja: build stopped: subcommand failed.
Error: module addHoursAndMinutes: Der Kindprozess wurde mit Status 1 beendet

My Manifest file is this:

{
  "app-id": "de.akaflieg_freiburg.cavok.add_hours_and_minutes",
  "runtime": "org.kde.Platform",
  "runtime-version": "6.7",
  "sdk": "org.kde.Sdk",
  "command": "addhoursandminutes",
  "finish-args": [
    "--share=ipc",
    "--socket=fallback-x11",
    "--socket=wayland",
    "--device=dri"
  ],
  "modules": [
    {
      "name": "addHoursAndMinutes",
      "buildsystem": "cmake-ninja",
      "sources": [
        {
          "type": "git",
          "url": "https://github.com/Akaflieg-Freiburg/addhoursandminutes.git",
          "commit": "a161685"
        }
      ]
    }
  ]
}

kebekus commented 3 weeks ago

Fixed and implemented.

@hfiguiere Thank you.

flathub / de.akaflieg_freiburg.cavok.add_hours_and_minutes

Change in build 117032 rejected #13

Changes