search

flathub / de.willuhn.Jameica

https://flathub.org/apps/details/de.willuhn.Jameica
0 stars 3 forks source link

Update Jameica runtime to 46 #35

Closed yakushabb closed 1 month ago

yakushabb commented 1 month ago
flathubbot commented 1 month ago

Started test build 126822

flathubbot commented 1 month ago

Build 126822 failed

flathubbot commented 1 month ago

Started test build 126834

flathubbot commented 1 month ago

Build 126834 failed

yakushabb commented 1 month ago

"appstream-missing-icon-file"

Exceptions allowed: No A 128px png icon was not generated by appstreamcli compose. This is generated automatically provided some conditions are met. The error indicates something else is wrong. Please review additional errors if present.

https://docs.flathub.org/docs/for-app-authors/linter/#appstream-missing-icon-file

bbhtt commented 1 month ago

The icon supplied is 64px only, it needs a 128px or more.

flathubbot commented 1 month ago

Started test build 128321

flathubbot commented 1 month ago

Build 128321 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/111308/de.willuhn.Jameica.flatpakref
flathubbot commented 1 month ago

Started test build 128322

flathubbot commented 1 month ago

Build 128322 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/111309/de.willuhn.Jameica.flatpakref
yakushabb commented 1 month ago

The icon supplied is 64px only, it needs a 128px or more.

@bbhtt Fixed.

tobias-hammerschmidt commented 1 month ago

Thanks for your contribution! I only have 2 questions/remarks wrt this PR:

  1. Have you checked whether Jameica already contains a high-res icon which we can directly install instead of putting it here in the repository?
  2. I haven't checked in detail but it looks like the changes in the metainfo.xml file will result in a mixture of english and german description?
flathubbot commented 1 month ago

Started test build 128528

flathubbot commented 1 month ago

Build 128528 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/111513/de.willuhn.Jameica.flatpakref
yakushabb commented 1 month ago

The archive file (https://willuhn.de/products/jameica/releases/current/jameica/jameica-linux64-2.10.4.zip) only contains one image (jameica-icon.png) with dimensions of 64px x 64px.

Fixed metainfo issues related to missing lang tags.

tobias-hammerschmidt commented 1 month ago

Fine then we'll go with the provided image.