search

flathub / de.willuhn.Jameica

https://flathub.org/apps/details/de.willuhn.Jameica
0 stars 3 forks source link

Home access #5

Closed webagentur-hartmann closed 2 years ago

flathubbot commented 2 years ago

Started test build 79498

flathubbot commented 2 years ago

Build 79498 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/77379/de.willuhn.Jameica.flatpakref
tobias-hammerschmidt commented 2 years ago

I think this addresses https://github.com/flathub/de.willuhn.Jameica/issues/4? If you could confirm that this fixes the download issue I would be fine merging this pr.

webagentur-hartmann commented 2 years ago

It addresses issue #4 . It is more a workaround, since it open access to sensitive folders like .ssh

tobias-hammerschmidt commented 2 years ago

In this case maybe it makes sense to restrict the access to xdg-documents and/or xdg-download (see https://docs.flatpak.org/en/latest/sandbox-permissions-reference.html#filesystem-permissions)?

webagentur-hartmann commented 2 years ago

As far as I understand it correct, the xdg-paths are by default subfolders of ~/.var/app/de.willuhn.Jameica .

EDIT: You are right. xdg-paths links subdirectories of the app to corresponding folders of the user.

But, I think that restricting access to these both folders will lead to confusion. IMHO, the focus group for Flatpaks are users coming from another OS, like Windows. There a user have full write access to its user directory. Restricting access to special folders is not know to them. I told to Olaf yesterday, that he got a lot of questions regarding to file permissions.

As already mentioned I just want to place it is just a workaround up to the next release. For upcoming releases I would prefer to use the default locations and just linking user-specific folders to this default locations. I am currently testing the usage of relative paths, so a usage of the profile on multiple OSes should be possible.