flathub / dev.vencord.Vesktop

https://flathub.org/apps/details/dev.vencord.Vesktop
10 stars 8 forks source link

fix appindicator icon #10

Closed SoMuchForSubtlety closed 8 months ago

SoMuchForSubtlety commented 8 months ago

Fixes #2

flathubbot commented 8 months ago

Started test build 94082

flathubbot commented 8 months ago

Build 94082 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/76827/dev.vencord.Vesktop.flatpakref
SoMuchForSubtlety commented 8 months ago

Build 94082 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/76827/dev.vencord.Vesktop.flatpakref

Fixes the issue for me

SoMuchForSubtlety commented 8 months ago

It just saw that the start script sets the TMPDIR variable, but AFAICT that has no effect.

https://github.com/flathub/dev.vencord.Vesktop/blob/1e709af7f51e282a702850744d73f240f1dfaab2/startvesktop#L3

Vendicated commented 8 months ago

indeed, that line should be export TMPDIR=

SoMuchForSubtlety commented 8 months ago

indeed, that line should be export TMPDIR=

Do you want me to revert my changes and fix the startup script instead?

lewisakura commented 8 months ago

yes, that is a typo that i did not notice - try locally first and see if it works if changed to export TMPDIR, then update the PR

flathubbot commented 8 months ago

Started test build 94395

flathubbot commented 8 months ago

Build 94395 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/77144/dev.vencord.Vesktop.flatpakref
SoMuchForSubtlety commented 8 months ago

Do you want any more changes?

azzamsa commented 8 months ago

Hi, 👋.

Any reason this PR is not getting merged? The tray icon/status was very crucial for my workflow.

Thank you for maintaining Vesktop!

lewisakura commented 8 months ago

waiting for it to be tested by more people on a variety of machines, if you would like to help please install it and see if it fixes the issue.