fix running with disabled wayland socket

Vendicated commented 4 days ago

🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑

Vendicated commented 4 days ago

bot, build

flathubbot commented 4 days ago

Queued test build for dev.vencord.Vesktop.

flathubbot commented 4 days ago

Started test build 132560

flathubbot commented 4 days ago

Build 132560 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/115565/dev.vencord.Vesktop.flatpakref

Sad-Soul-Eater commented 4 days ago

@Vendicated Hi, I believe this PR broke Vesktop on my system with the next error:

Using NVIDIA on Wayland, disabling gpu sandbox
Passing the following arguments to Electron: --enable-speech-dispatcher --disable-gpu-sandbox
[3:0705/115002.085635:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
APPIMAGE env is not defined, current application is not an AppImage
checkForUpdatesAndNotify called, downloadPromise is null
[3:0705/115002.245507:ERROR:ozone_platform_x11.cc(245)] Missing X server or $DISPLAY
[3:0705/115002.245520:ERROR:env.cc(258)] The platform failed to initialize.  Exiting.
/app/bin/startvesktop: line 22:     3 Segmentation fault      (core dumped) zypak-wrapper /app/bin/vesktop/vesktop.bin "${FLAGS[@]}" "$@"

I think this issue occurred because the Wayland socket in my system is located under /run/flatpak/wayland-0 but your script is trying to find it in $XDG_RUNTIME_DIR/${WAYLAND_SOCKET} which resolves into /run/user/1000/wayland-0 (it's not here).

Also, there is next env var: WAYLAND_DISPLAY=/run/flatpak/wayland-0

And if I run /app/bin/startvesktop --ozone-platform-hint=auto manually all works fine under the Wayland

System info: Distro: Arch Linux Flatpak: 1.15.8

Vesktop:

          ID: dev.vencord.Vesktop
         Ref: app/dev.vencord.Vesktop/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 1.5.2
     License: GPL-3.0
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 281.3 MB
     Runtime: org.freedesktop.Platform/x86_64/23.08
         Sdk: org.freedesktop.Sdk/x86_64/23.08

      Commit: 0e79f0fb9ced35d6924de91fecec367a59fce5c37c2fd7a57ec0ef9cb1b91a82
      Parent: 5b639112007e4d324118ef7adf930de3b7b074ea1201957e815911c5d7b51778
     Subject: Vesktop: Update Vesktop.AppImage to 1.5.3 (#25) (37016c1a)
        Date: 2024-07-04 21:03:43 +0000

flathub / dev.vencord.Vesktop

fix running with disabled wayland socket #23