flathub / dev.zed.Zed

https://flathub.org/apps/details/dev.zed.Zed
9 stars 3 forks source link

update to v0.152.3 + fix x-checker-data #15

Closed tomaswarynyca closed 2 days ago

tomaswarynyca commented 1 week ago

Now you can use this command to update flatpak run org.flathub.flatpak-external-data-checker --edit-only ./dev.zed.Zed.yaml

flathubbot commented 1 week ago

Started test build 145557

flathubbot commented 1 week ago

Build 145557 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/128643/dev.zed.Zed.flatpakref
tomaswarynyca commented 1 week ago

@ShobuPrime can you check this please? I would also appreciate if you consider that I can have access to be maintainer of the project so I don't have to be bothering you to update it - you would have to create an issue requesting to add me to the repo in flathub/flathub

rashadgasimli commented 2 days ago

Build 145557 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/128643/dev.zed.Zed.flatpakref

the link is not working anymore

tomaswarynyca commented 2 days ago

@bbhtt can you check this please? Also, once you merge this, can you configure flathubbot to generate the PRs automatically?

bbhtt commented 2 days ago

X-checker runs for all repos hourly it will generate PRs automatically. You only need the relevant x-checker stanza in the manifest to make it work

ShobuPrime commented 2 days ago

@ShobuPrime can you check this please? I would also appreciate if you consider that I can have access to be maintainer of the project so I don't have to be bothering you to update it - you would have to create an issue requesting to add me to the repo in flathub/flathub

Based on this comment, @bbhtt mentioned automatic PR merges weren't allowed anymore (at least from the perspective of flathub.json).

@bbhtt -- If we were to build a Github action to check if a PR is simply updating the hash and version numbers correctly and automatically merge that way, is that allowed?

As for being an additional maintainer, based on this comment we will need to:

Create an issue at https://github.com/flathub/flathub/ detailing who needs inviting (or removing) and someone will handle it.

tomaswarynyca commented 2 days ago

Now that this PR modifies “x-checker-data” with a working config, flathubbot will check every 1hs if a new version exists and will generate a PR if necessary. That modifies the version and sha256 - causing the bot to generate a new build to verify that it works properly and have a PR ready to be merged.

bbhtt commented 2 days ago

Yes whenever a new version is released upstream the bot will submit a PR with an update. You just need to merge it. There is no need for any GitHub action.