feat: flatpak no escape, ide-wrapper, solves #6

[flathubbot]

Started test build 140759

[flathubbot]

Build 140759 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123807/dev.zed.Zed.flatpakref

[flathubbot]

Started test build 141382

[flathubbot]

Started test build 141383

[flathubbot]

Build 141382 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/124436/dev.zed.Zed.flatpakref

[flathubbot]

Build 141383 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/124437/dev.zed.Zed.flatpakref

[flathubbot]

Started test build 141938

[flathubbot]

Build 141938 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/124991/dev.zed.Zed.flatpakref

[jerome-benoit]

The build behaves as intended with env variables.

@baronleonardo: do you also confirm?

[baronleonardo]

• this build flatpak install --user https://dl.flathub.org/build-repo/124991/dev.zed.Zed.flatpakref gave me 404
• for the current release, no it doesn't work

[flathubbot]

Started test build 143668

[flathubbot]

Build 143668 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/126729/dev.zed.Zed.flatpakref

[jerome-benoit]

• this build flatpak install --user https://dl.flathub.org/build-repo/124991/dev.zed.Zed.flatpakref gave me 404

And with the latest build?

[baronleonardo]

I can confirm that this build flatpak install --user https://dl.flathub.org/build-repo/126729/dev.zed.Zed.flatpakref is working as expected

[jerome-benoit]

I can confirm that this build flatpak install --user https://dl.flathub.org/build-repo/126729/dev.zed.Zed.flatpakref is working as expected

@ShobuPrime: can it be considered for merge? It will permit people using the flatpak and nvidia driver to run Zed: https://github.com/zed-industries/zed/issues/17129#issuecomment-2323974189

[flathubbot]

Started test build 144400

[flathubbot]

Started test build 144401

[flathubbot]

Build 144400 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/127475/dev.zed.Zed.flatpakref

[flathubbot]

Build 144401 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/127476/dev.zed.Zed.flatpakref

[jerome-benoit]

@appelgriebsch: mixing version upgrade + feature/fix in the same PR with not help at merging it ...:

• more conflicts expected
• less orthogonality in commits

[flathubbot]

Started test build 144408

[flathubbot]

Started test build 144409

[appelgriebsch]

Not sure if it makes it easier to just merge this one and then update to latest version.... but feel free to decide what fit you better

[flathubbot]

Build 144408 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/127483/dev.zed.Zed.flatpakref

[flathubbot]

Build 144409 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/127484/dev.zed.Zed.flatpakref

[jerome-benoit]

Not sure if it makes it easier to just merge this one and then update to latest version.... but feel free to decide what fit you better

The Zed flatpak repo is maintained by only one person? There's no backup?

[tomaswarynyca]

@ShobuPrime can you check this please?

[flathubbot]

Started test build 144681

[flathubbot]

Build 144681 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/127757/dev.zed.Zed.flatpakref

[tomaswarynyca]

@appelgriebsch can you fix the PR so it doesn't delete 0.151.1?

[jerome-benoit]

appelgriebsch force-pushed the feature/flatpak-no-escape branch from 46a2ecc to c72baa7. 30 minutes ago

By untangling the Zed version update from the wrapper introduction PR, you do not need to maintain the later: no more conflicts to handle and the repo maintainer just has to eventually sync it with main branch before merge.

[flathubbot]

Started test build 144685

[flathubbot]

Build 144685 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/127761/dev.zed.Zed.flatpakref

[ShobuPrime]

I'm not necessarily against merging this PR, but I do have some suggestions we'll need to consider before merge:

Very early in the building process @ConradIrwin has mentioned:

It makes me very unhappy to think that we’d ship a partially non-functional zed on flathub

I'm quoting this because the Flatpak now has more than 14k downloads -- existing users are going to expect the "default" behavior of escaping the sandbox. If we switch the default behavior on them now with no notice, it would just create un-needed bug reports.

I believe we need to update both the Metainfo.xml and firstrun.txt with a clear disclaimer in the description to change the ZED_FLATPAK_NO_ESCAPE variable if they want to use the host's runtimes and binaries outside of the sandbox.

Has the Flatpak been tested inside the sandbox with examples such as: FLATPAK_ENABLE_SDK_EXT="golang"? In addition, I don't have a device with an Nvidia GPU at the moment, so I'm unable to test the Nvidia driver mentioned here, but I trust some of you have already made sure it works.

@jerome-benoit We can add more maintainers to this repo with the following instructions. I could certainly use some more help.

[jerome-benoit]

Very early in the building process @ConradIrwin has mentioned:

It makes me very unhappy to think that we’d ship a partially non-functional zed on flathub

The current Zed on flathub is not offering the same user experience than installing Zed via the install script: zed in not available via the CLI and respecting env variables. Aligning the user experience with the behavior end users expect is actually a bug fix. Dunno why it was shipped without CLI usage consideration.

@appelgriebsch: @ShobuPrime is right, changing ZED_FLATPAK_NO_ESCAPE current default is not necessary to properly expose zed binary through the CLI respecting env variables. It's in fact an orthogonal change that can be part of other PR and discussion more related to Zed flatpak security.

I don't have a device with an Nvidia GPU at the moment, so I'm unable to test the Nvidia driver mentioned here, but I trust some of you have already made sure it works.

As long as the zed binary launched has read access to the env variables, it will work.

[baronleonardo]

why had this been closed and deleted ?!