search

flathub / electron-sample-app

Sample application based on electron
GNU General Public License v3.0
25 stars 11 forks source link

Update Readme with details about how to Add/Update generated-sources.json #12

Closed andirsun closed 7 months ago

andirsun commented 7 months ago

Hey! I was following the official electron documentation for flatpak, I realize that this repo does not contain a link to that tutorial (https://github.com/flathub/electron-sample-app/issues/3#issue-802770776) So in order to make this repo more easy to follow for new users building flatpaks like me, we can add information which commands users can use to generate generated-sources.json.

 flatpak-node-generator npm package-lock.json
cpba commented 7 months ago

You just added a link to the tutorial in https://github.com/flathub/electron-sample-app/pull/13/commits/699671fd356fa7786baf84f4072643ea9bb38cae.

The tutorial already explains how to create the file in the Bundling NPM packages section, should this issue be closed then?

andirsun commented 7 months ago

You are probably right !